Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for battery info and M5LED fix for M5Stickc plus2 #63

Merged
merged 6 commits into from
Jan 26, 2024

Conversation

chr0m1ng
Copy link
Contributor

@chr0m1ng chr0m1ng commented Jan 12, 2024

This PR adds the feature PWRMGMT to use M5.Power to get battery information for the M5Stickc plus2.
This also add/fix M5 LED for M5Stickc plus2.

@n0xa
Copy link
Owner

n0xa commented Jan 17, 2024

Can you see if the battery level work in the develop branch works? There was an older PR covering this.

@chr0m1ng
Copy link
Contributor Author

chr0m1ng commented Jan 18, 2024

Can you see if the battery level work in the develop branch works? There was an older PR covering this.

It doesn't even appear on the settings page, also you have an issue with the PT_BR version in m5stick-nemo.ino#L480 where is XT_ROTATION should be TXT_ROTATION

IMG_9869

@chr0m1ng chr0m1ng changed the title Support for battery info and led in M5Stickc plus2 Support for battery info for M5Stickc plus2 Jan 18, 2024
@chr0m1ng chr0m1ng changed the title Support for battery info for M5Stickc plus2 Support for battery info and M5LED fix for M5Stickc plus2 Jan 18, 2024
@chr0m1ng
Copy link
Contributor Author

chr0m1ng commented Jan 18, 2024

@n0xa I've changed the PR to support localization, fixed the misspelled txt rotation and moved the M5LED ON/OFF values to macros, cause in M5StickcPlus2 if you set HIGH it will turn on (not off), which was causing the M5LED to be ON all the time

@n0xa n0xa merged commit daa851c into n0xa:develop Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants