You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I was writing a test, I noticed that in most cases you keep the first instance of a tag. All the others will be ignored.
I did not test all the tags or look at your code, but some tags can and are even expected to be duplicated.
Specifically, the TXXX tag has to be distinguished from its label and not the tag itself.
You add tag function works:
id3Tag.AddUserDefinedTextFrame(someFrame)
since it adds a new tag. However, it works the other way around: it accepts new entries which are potentially duplicates.
So... if you find two entries that looks like:
TXXX <size> <flags> 3 <name> \0 <data>
and the <name> are different, keep both in the order they were added. If the user calls AddUserDefinedText(). The reading of the tags should probably make use of the same add functions so that way you do not have to repeat that logic everywhere.
As I was writing a test, I noticed that in most cases you keep the first instance of a tag. All the others will be ignored.
I did not test all the tags or look at your code, but some tags can and are even expected to be duplicated.
Specifically, the
TXXX
tag has to be distinguished from its label and not the tag itself.You add tag function works:
since it adds a new tag. However, it works the other way around: it accepts new entries which are potentially duplicates.
So... if you find two entries that looks like:
and the
<name>
are different, keep both in the order they were added. If the user callsAddUserDefinedText()
. The reading of the tags should probably make use of the same add functions so that way you do not have to repeat that logic everywhere.Documentation: http://id3.org/id3v2.3.0#User_defined_text_information_frame
The text was updated successfully, but these errors were encountered: