Add support for reading the id3 from a stream reader #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n10v
requested changes
May 11, 2017
id3v2.go
Outdated
|
|
||
| // OpenStream parses opened stream and finds tag in it considering opts. | ||
| // If there is no tag in stream, OpenStream will create new one with version ID3v2.4. | ||
| // you can use WriteTo to get the metadata |
There was a problem hiding this comment.
Please delete this line. IMHO it's confusing.
parse.go
Outdated
| func parseTag(file *os.File, opts Options) (*Tag, error) { | ||
| if file == nil { | ||
| return nil, errors.New("file is nil") | ||
| func parseTag(reader io.Reader, opts Options) (*Tag, error) { |
id3v2.go
Outdated
| // OpenStream parses opened stream and finds tag in it considering opts. | ||
| // If there is no tag in stream, OpenStream will create new one with version ID3v2.4. | ||
| // you can use WriteTo to get the metadata | ||
| func OpenStream(stream io.Reader, opts Options) (*Tag, error) { |
There was a problem hiding this comment.
IMHO It's better to name it ParseReader.
tag.go
Outdated
| @@ -263,6 +266,10 @@ func (t *Tag) SetVersion(version byte) { | |||
| // Save writes t to the file. If there are no frames in tag, Save will write | |||
| // only music part without any ID3v2 information. | |||
| func (t *Tag) Save() error { | |||
| if t.file == nil { | |||
| return fmt.Errorf("Parser not inited with file, it's just a stream") | |||
There was a problem hiding this comment.
I think, we should create special error for it and return it:
// ErrNoFile is returned in Save and Close method, if tag was not
// initialized with file.
var ErrNoFile = errors.New('tag was not initialized with file')And then write in docs of Save and Close these lines:
// If tag was initiliazed not with file but from ParseReader,
// it returns ErrNoFile.| @@ -393,5 +400,9 @@ func writeFrameHeader(bw *bufio.Writer, id string, frameSize int) error { | |||
| // Close closes t's file, rendering it unusable for I/O. | |||
| // It returns an error, if any. | |||
| func (t *Tag) Close() error { | |||
| if t.file == nil { | |||
|
Done I'm using this library to parse id3 from an audio received from http. |
n10v
approved these changes
May 12, 2017
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for using a simple reader as source for the parser. The changes are backward compatible.