Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to generate a new id3 data without having a stream to sta… #22

Merged
merged 2 commits into from
May 15, 2017

Conversation

corneldamian
Copy link
Contributor

@corneldamian corneldamian commented May 15, 2017

add support to generate a new id3 data without having a stream to start from

Copy link
Owner

@n10v n10v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, it's a nice feature! But please fix these small things.

id3v2.go Outdated
@@ -81,3 +81,8 @@ func Open(name string, opts Options) (*Tag, error) {
func ParseReader(rd io.Reader, opts Options) (*Tag, error) {
return parseTag(rd, opts)
}

//Generate an empty id3 tag without having a stream to start from
func Empty() *Tag {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func NewEmptyTag() *Tag {

id3v2.go Outdated
@@ -81,3 +81,8 @@ func Open(name string, opts Options) (*Tag, error) {
func ParseReader(rd io.Reader, opts Options) (*Tag, error) {
return parseTag(rd, opts)
}

//Generate an empty id3 tag without having a stream to start from
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// NewEmptyTag returns an empty ID3v2.4 tag without any frames and reader.

@n10v n10v merged commit e0f7c8c into n10v:master May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants