Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upClicking last page in pagination reverts to first page #18
Conversation
This comment has been minimized.
This comment has been minimized.
I added that in as part of fixing #7 as if the page number exceeded the length of the list, it through one of those 'content changed after view render' errors... which are harmless...ish but unsightly in dev. I suspect this is just one of those good-old off-by-one errors. Would you mind changing it to |
This comment has been minimized.
This comment has been minimized.
I applied the patch above and that fixed it without removing the reset to page 1 if it overflows. Thanks for the heads-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
s-arika commentedOct 21, 2019
Fixes for #17
I removed
if (this._page * this.itemsPerPage > this.totalItems) { this._page = 1; }
If the page is at 4 and it's multiplied by 500, it exceeds the total items. I believe this is causing the page to revert to 1.