This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
Workaround on phantomjs to support phantomjs 1.9.8 #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelandrieu
force-pushed
the
phantom-workaround
branch
from
4e7ee67
to
2d8a7a5
Compare
mickaelandrieu
force-pushed
the
phantom-workaround
branch
from
a9a2207
to
4106f19
Compare
mickaelandrieu
added a commit
that referenced
this pull request
Jan 29, 2015
Workaround on phantomjs to support phantomjs 1.9.8
|
@mickaelandrieu should there be a comment in the new code stating that it is needed only for the given workaround? Also, I don't quite understand why there was a PR which was very soon merged by the same person. Please correct me if I am wrong, but wouldn't the point of having a PR is for possible comments and someone else to merge it? |
|
Hi, As you may now, CasperJS build is broken since months and as stated in link in my PR, the workaround is known and already used in some others tools from phantomjs family. Afaik only @n1k0 and I can merge and he is busy since and for months. I will make a PR for future contribution, I'm glad to see new active contributors 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed Unsafe Javascript attempt, see ariya/phantomjs#12697 for workaround suggested.