This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Add a DaybedStorage PoC #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I used componentDidMount and it worked :) |
| componentDidMount: function() { | ||
| this.props.store.load() | ||
| .then(function(items) { | ||
| if (this.isMounted()) { |
There was a problem hiding this comment.
You're in componentDidMount, component is necessarily mounted.
| for (var i = 0; i < doc.records.length; i++) { | ||
| var record = doc.records[i]; | ||
| record.type = type; | ||
| data.push(record); |
There was a problem hiding this comment.
Nit:
data = doc.records.map(function(record) {
record.type = type;
return record;
});There was a problem hiding this comment.
Well you don't want to override data at this point.
There was a problem hiding this comment.
But I can still use map 👍
There was a problem hiding this comment.
race condition detected with data.concat
There was a problem hiding this comment.
Well maybe not, let me try.
There was a problem hiding this comment.
I'd be very surprised if concat would where a for loop wouldn't.
added 2 commits
August 4, 2014 18:17
| try { | ||
| this._store["keep.data"] = JSON.stringify(data); | ||
| } catch (e) { | ||
| console.error("failed saving keep data", e); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of things to change before it works:
Hope @n1k0 can help me on this.