Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useValidationRule() plugin #2215

Merged
merged 4 commits into from
May 7, 2024
Merged

Add useValidationRule() plugin #2215

merged 4 commits into from
May 7, 2024

Conversation

benjie
Copy link
Contributor

@benjie benjie commented Apr 22, 2024

Description

As discussed with @n1ru4l, this adds the useValidationRule() plugin, which can be used to add a validation rule.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • Added to your test suite

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

The newrelic tests are failing locally; I think this is unrelated given how trivial the function I've added is.

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 1f56053

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie
Copy link
Contributor Author

benjie commented Apr 23, 2024

I do not know how to address these test failures. I do not think it's related to my changes?

@n1ru4l n1ru4l merged commit dc1222f into n1ru4l:main May 7, 2024
15 checks passed
@benjie benjie deleted the validation-rule branch May 7, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants