Some changes to track parsing #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 31, 2018 11:57
Tracks may have tracknumber and discnumber formatted as "x/y" where: - x is the current track/disc number - y is the total number of tracks/discs For example this is the case for tracks downloaded from Google Play Music. Now `parse_resource` function considers this particular case, otherwise will stick with the normal behaviour
Since date tag inside tracks is a string, it can have any possible value. Previous code tried to parse date as an integer, but for example strings such as "2017-11-12 14:34" can't be cast to an integer value. As a workaround, date is now parsed as is, and the application client should handle its value as it sees fit
n1zzo
reviewed
Jan 31, 2018
tersicore/formats.py
Outdated
| track_number = None | ||
| if total_tracks == "0": | ||
| total_tracks = None | ||
| if type(track_number) is str and len(track_number) == 1: |
There was a problem hiding this comment.
Use rjust to pad here, like: track_number.rjust(2, "0").
n1zzo
reviewed
Jan 31, 2018
tersicore/formats.py
Outdated
| if disc_number == "0": | ||
| disc_number = None | ||
| if total_discs == "0": | ||
| total_discs = None |
There was a problem hiding this comment.
Why track_number is padded and disc_number is not?
n1zzo
reviewed
Jan 31, 2018
tersicore/formats.py
Outdated
| @@ -101,8 +101,7 @@ def parse_resource(res, path): | |||
| res.track.isrc = parse('isrc', media.tags) | |||
|
|
|||
| raw_date = parse('date', media.tags) | |||
| if raw_date not in [None, '']: | |||
| res.track.date = date(int(raw_date), 1, 1) | |||
| res.track.date = raw_date | |||
There was a problem hiding this comment.
Can we just do some better parsing? Check out dateutil.parser.parse.
|
Hi, I've reviewed some of your commits, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For explanation about commits, check the full commit message