Removed glass rect. Fixed events for scrubber. #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work ! One remark, though : the click/hover events won't fire on anything but the columns, because the line/area dots (or the dots themselves for a dot series) will be hidden by the scrubber... |
|
yeah, you are right. now it should work ;) |
chaosmail
force-pushed
the
fix/glass-container
branch
from
5223731
to
70ec55a
Compare
|
Alright, I enhanced the tests a little bit and rebased to master |
|
Dude, this is great work. 🍗 |
lorem--ipsum
pushed a commit
that referenced
this pull request
Sep 21, 2015
Removed glass rect. Fixed events for scrubber.
lorem--ipsum
pushed a commit
that referenced
this pull request
Nov 3, 2015
Removed glass rect. Fixed events for scrubber.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the most crazy PR since i started with n3-charts.
mousemovetosvgnode)Here is an example for click and hover in scrubber mode: http://plnkr.co/edit/LByntodp64Dt3m0roAC9?p=preview
Fixes #324
Fixes #270
Best,
Christoph