Refactor: Replace Pipenv with requirements.txt for dependency management #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove pipenv from Dockerfile - update the readme: * update prerequisites * use venv while installing from source * update docker compose command syntax * add a note about rebuilding docker images
Keonik1
suggested changes
Mar 18, 2023
README.md
Outdated
Comment on lines
136
to
138
| **Note:** After updating `.env` file, you have to rebuild the image: | ||
| ```shell | ||
| docker compose up --build |
There was a problem hiding this comment.
This is not necessary, since the file is mounted when the container is started.
More correctly:
After the change .env file restart docker container:
docker-compose down
docker-compose upIf they have been changed .py files, then you need to rebuild the docker image:
docker-compose down
docker-compose up --buildThere was a problem hiding this comment.
aaw, I see. I should have checked the compose file more accurately.
Just pushed a fix.
Please note that I kept the new docker compose command syntax standard which came from the built-in compose feature (on the readme).
* update readme
bugfloyd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
* add a note about rebuilding docker imagesResolves #78