Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing 4 bits representing PUS version number in TC/TM secondary headers. #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cierpuchaw
Copy link
Collaborator

No description provided.

@cierpuchaw cierpuchaw requested a review from hcorg March 17, 2023 19:00
@@ -45,7 +45,7 @@ TC-PacketDataField <INTEGER:secondaryHeaderFlag> []
TC-DataWithSecondaryHeader []
{
secondaryHeader [] {
tcPacketPusVersionNumber [],
tcPacketPusVersionNumber NULL [pattern '0010'B],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should either use or delete PacketVersionNumber structure.

https://github.com/n7space/asn1-pusc-lib/blob/master/ccsds/PacketTypes.asn1#L38

I have a feeling, that it was supposed to go here but something was not working... hence the strange NULL in ASN.1...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants