Skip to content

Commit

Permalink
fix(editor): Fix and report settings being null in workflow paylo…
Browse files Browse the repository at this point in the history
…ads (no-changelog) (#9227)
  • Loading branch information
ivov committed Apr 26, 2024
1 parent 99f384e commit 11a3572
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions packages/editor-ui/src/stores/workflows.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ import { useUsersStore } from '@/stores/users.store';
import { useSettingsStore } from '@/stores/settings.store';
import { getCredentialOnlyNodeTypeName } from '@/utils/credentialOnlyNodes';
import { i18n } from '@/plugins/i18n';
import { ErrorReporterProxy as EventReporter } from 'n8n-workflow';

const defaults: Omit<IWorkflowDb, 'id'> & { settings: NonNullable<IWorkflowDb['settings']> } = {
name: '',
Expand Down Expand Up @@ -1312,6 +1313,12 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, {
forceSave = false,
): Promise<IWorkflowDb> {
const rootStore = useRootStore();

if (data.settings === null) {
EventReporter.info('Detected workflow payload with settings as null');
data.settings = undefined;
}

return await makeRestApiRequest(
rootStore.getRestApiContext,
'PATCH',
Expand All @@ -1322,6 +1329,12 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, {

async runWorkflow(startRunData: IStartRunData): Promise<IExecutionPushResponse> {
const rootStore = useRootStore();

if (startRunData.workflowData.settings === null) {
EventReporter.info('Detected workflow payload with settings as null');
startRunData.workflowData.settings = undefined;
}

try {
return await makeRestApiRequest(
rootStore.getRestApiContext,
Expand Down

0 comments on commit 11a3572

Please sign in to comment.