✨ Adding force flag to credentials fetching (#3527)

* ✨ Adding `force` flag to credentials fetching which can be used to skip check when loading credentials * ✨ Forcing credentials loading when opening nodeView
n8n-io · Jun 16, 2022 · 2aa6b8f · 2aa6b8f
1 parent cb5a67d
commit 2aa6b8f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/editor-ui/src/components/mixins/pushConnection.ts b/packages/editor-ui/src/components/mixins/pushConnection.ts
@@ -355,7 +355,7 @@ export const pushConnection = mixins(
 					const nodesToBeFetched: INodeTypeNameVersion[] = [pushData];
 
 					// Force reload of all credential types
-					this.$store.dispatch('credentials/fetchCredentialTypes')
+					this.$store.dispatch('credentials/fetchCredentialTypes', true)
 						.then(() => {
 							// Get the data of the node and update in internal storage
 							return this.restApi().getNodesInformation(nodesToBeFetched);

diff --git a/packages/editor-ui/src/modules/credentials.ts b/packages/editor-ui/src/modules/credentials.ts
@@ -152,8 +152,8 @@ const module: Module<ICredentialsState, IRootState> = {
 		},
 	},
 	actions: {
-		fetchCredentialTypes: async (context: ActionContext<ICredentialsState, IRootState>) => {
-			if (context.getters.allCredentialTypes.length > 0) {
+		fetchCredentialTypes: async (context: ActionContext<ICredentialsState, IRootState>, forceFetch: boolean) => {
+			if (context.getters.allCredentialTypes.length > 0 && forceFetch !== true) {
 				return;
 			}
 			const credentialTypes = await getCredentialTypes(context.rootGetters.getRestApiContext);

diff --git a/packages/editor-ui/src/views/NodeView.vue b/packages/editor-ui/src/views/NodeView.vue
@@ -2834,7 +2834,7 @@ export default mixins(
 				this.$store.commit('setNodeTypes', nodeTypes);
 			},
 			async loadCredentialTypes (): Promise<void> {
-				await this.$store.dispatch('credentials/fetchCredentialTypes');
+				await this.$store.dispatch('credentials/fetchCredentialTypes', true);
 			},
 			async loadCredentials (): Promise<void> {
 				await this.$store.dispatch('credentials/fetchAllCredentials');