fix(next-cloud-node): Fix issue with credential verification and shar…

…ing file
n8n-io · Aug 19, 2022 · 2b4f5c6 · 2b4f5c6
1 parent 1161761
commit 2b4f5c6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/nodes-base/nodes/NextCloud/GenericFunctions.ts b/packages/nodes-base/nodes/NextCloud/GenericFunctions.ts
@@ -21,8 +21,7 @@ export async function nextCloudApiRequest(
 	headers?: object,
 	encoding?: null | undefined,
 	query?: object,
-	// tslint:disable-next-line:no-any
-): Promise<any> {
+) {
 	const resource = this.getNodeParameter('resource', 0);
 	const operation = this.getNodeParameter('operation', 0);
 	const authenticationMethod = this.getNodeParameter('authentication', 0);
@@ -49,10 +48,15 @@ export async function nextCloudApiRequest(
 	}
 
 	options.uri = `${credentials.webDavUrl}/${encodeURI(endpoint)}`;
+
 	if (resource === 'user' && operation === 'create') {
 		options.uri = options.uri.replace('/remote.php/webdav', '');
 	}
 
+	if (resource === 'file' && operation === 'share') {
+		options.uri = options.uri.replace('/remote.php/webdav', '');
+	}
+
 	const credentialType =
 		authenticationMethod === 'accessToken' ? 'nextCloudApi' : 'nextCloudOAuth2Api';
 

diff --git a/packages/nodes-base/nodes/NextCloud/NextCloud.node.ts b/packages/nodes-base/nodes/NextCloud/NextCloud.node.ts
@@ -1,5 +1,5 @@
 import { IExecuteFunctions } from 'n8n-core';
-import { NodeApiError } from 'n8n-workflow';
+import { IBinaryKeyData, NodeApiError } from 'n8n-workflow';
 
 import {
 	IDataObject,
@@ -1139,7 +1139,7 @@ export class NextCloud implements INodeType {
 						// Create a shallow copy of the binary data so that the old
 						// data references which do not get changed still stay behind
 						// but the incoming data does not get changed.
-						Object.assign(newItem.binary, items[i].binary);
+						Object.assign(newItem.binary as IBinaryKeyData, items[i].binary);
 					}
 
 					items[i] = newItem;