-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* ci: Add PR checklist * chore: add test change * ci: add name * ci: merge into workfow * test: test action * ci: add checklist * ci: test checklist * ci: remove comment * ci: test checklist * ci: add item to check item * ci: update checklist items * ci: add checklist item for migraitons * ci: add hooks checklist item * chore: remove comment
- Loading branch information
Showing
2 changed files
with
52 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
paths: | ||
"packages/**": | ||
- If fixing bug, added test to cover scenario. | ||
- If addressing forum or Github issue, added link to description. | ||
"packages/**/*.ts": | ||
- Added unit tests to cover new or updated functionality. | ||
"**/*.vue": | ||
- Used composition API for all new components. | ||
- Added component or unit tests to cover functionality. | ||
|
||
# cli | ||
"packages/cli/src/databases/migrations/**": | ||
- Requested review from at least two engineers on migration. | ||
- Avoided irreversible data migrations. | ||
- Avoided deleting or updating data keys. | ||
- Wrote 'down' migration if possible. | ||
"n8n/packages/cli/src/api/**": | ||
- Added integration tests for new endpoints. | ||
|
||
# editor ui | ||
"packages/editor-ui/**/*.vue": | ||
- Added E2E if adding new features. | ||
- Used design system tokens (colors, spacings...) where possible. | ||
"packages/editor-ui/src/mixins/restApi.ts": | ||
- Avoided adding new methods. Only deleted from here. | ||
"packages/editor-ui/src/mixins/**": | ||
- Avoided adding new mixins (use composables instead). Only removed code from here. | ||
"packages/editor-ui/src/views/NodeView.vue": | ||
- Avoided adding code here. Only refactored to make it smaller. | ||
"packages/editor-ui/src/hooks/**": | ||
- Avoided adding new hooks. Only refactored to move hooks to relevant store instead. | ||
|
||
# nodes-base | ||
"packages/nodes-base/nodes/**": | ||
- Added workflow tests for nodes if possible. | ||
|
||
# design-system | ||
"packages/design-system/**/*.vue": | ||
- Used design system tokens (colors, spacings...) where possible. | ||
- Updated Storybook with new component or updated functionality. |