fix: Fix vue type warnings (no-changelog) (#9038)

n8n-io · Apr 3, 2024 · 77b359a · 77b359a
1 parent 83e4739
commit 77b359a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/packages/design-system/src/components/N8nIcon/Icon.vue b/packages/design-system/src/components/N8nIcon/Icon.vue
@@ -5,14 +5,15 @@
 </template>
 
 <script lang="ts" setup>
+import type { FontAwesomeIconProps } from '@fortawesome/vue-fontawesome';
 import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome';
 import type { IconSize, IconColor } from '@/types/icon';
 import N8nText from '../N8nText';
 
 interface IconProps {
-	icon: string;
+	icon: FontAwesomeIconProps['icon'];
 	size?: IconSize;
-	spin?: boolean;
+	spin?: FontAwesomeIconProps['spin'];
 	color?: IconColor;
 }
 

diff --git a/packages/design-system/src/components/N8nRadioButtons/RadioButtons.vue b/packages/design-system/src/components/N8nRadioButtons/RadioButtons.vue
@@ -27,7 +27,8 @@ interface RadioOption {
 interface RadioButtonsProps {
 	modelValue?: string;
 	options?: RadioOption[];
-	size: 'small' | 'medium';
+	/** @default medium */
+	size?: 'small' | 'medium';
 	disabled?: boolean;
 }
 

diff --git a/packages/design-system/src/types/button.ts b/packages/design-system/src/types/button.ts
@@ -13,7 +13,7 @@ export interface IconButtonProps {
 	active?: boolean;
 	disabled?: boolean;
 	float?: TextFloat;
-	icon?: string;
+	icon?: string | string[];
 	loading?: boolean;
 	outline?: boolean;
 	size?: ButtonSize;

diff --git a/packages/editor-ui/src/components/Sticky.vue b/packages/editor-ui/src/components/Sticky.vue
@@ -52,7 +52,7 @@
 					v-touch:tap="deleteNode"
 					class="option"
 					data-test-id="delete-sticky"
-					:title="$locale.baseText('node.deleteNode')"
+					:title="$locale.baseText('node.delete')"
 				>
 					<font-awesome-icon icon="trash" />
 				</div>