fix: Permission object is not optional in test function

n8n-io · Nov 22, 2023 · d403b14 · d403b14
1 parent 6d7c77e
commit d403b14
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/editor-ui/src/__tests__/permissions.spec.ts b/packages/editor-ui/src/__tests__/permissions.spec.ts
@@ -47,8 +47,8 @@ describe('parsePermissionsTable()', () => {
 
 	it('should pass permission to test functions', () => {
 		const permissions = parsePermissionsTable(user, [
-			{ name: 'canRead', test: (p) => !!p?.isInstanceOwner },
-			{ name: 'canUpdate', test: (p) => !!p?.canRead },
+			{ name: 'canRead', test: (p) => !!p.isInstanceOwner },
+			{ name: 'canUpdate', test: (p) => !!p.canRead },
 		]);
 
 		expect(permissions.canRead).toBe(true);

diff --git a/packages/editor-ui/src/permissions.ts b/packages/editor-ui/src/permissions.ts
@@ -23,7 +23,7 @@ export const enum UserRole {
 
 export type IPermissions = Record<string, boolean>;
 
-type IPermissionsTableRowTestFn = (permissions?: IPermissions) => boolean;
+type IPermissionsTableRowTestFn = (permissions: IPermissions) => boolean;
 
 export interface IPermissionsTableRow {
 	name: string;
@@ -104,11 +104,11 @@ export const getWorkflowPermissions = (user: IUser | null, workflow: IWorkflowDb
 		},
 		{
 			name: 'updateSharing',
-			test: (permissions) => rbacStore.hasScope('workflow:update') || !!permissions?.isOwner,
+			test: (permissions) => rbacStore.hasScope('workflow:update') || !!permissions.isOwner,
 		},
 		{
 			name: 'delete',
-			test: (permissions) => rbacStore.hasScope('workflow:delete') || !!permissions?.isOwner,
+			test: (permissions) => rbacStore.hasScope('workflow:delete') || !!permissions.isOwner,
 		},
 	];