fix(SSH Node): Private key field as password and credential test (#6298)

n8n-io · May 23, 2023 · d5c7e6f · d5c7e6f
1 parent bbe6d4c
commit d5c7e6f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/nodes-base/credentials/SshPrivateKey.credentials.ts b/packages/nodes-base/credentials/SshPrivateKey.credentials.ts
@@ -35,6 +35,7 @@ export class SshPrivateKey implements ICredentialType {
 			type: 'string',
 			typeOptions: {
 				rows: 4,
+				password: true,
 			},
 			default: '',
 		},

diff --git a/packages/nodes-base/nodes/Ssh/Ssh.node.ts b/packages/nodes-base/nodes/Ssh/Ssh.node.ts
@@ -47,6 +47,14 @@ async function resolveHomeDir(
 	return path;
 }
 
+function sanitizePrivateKey(privateKey: string) {
+	const [openSshKey, bodySshKey, endSshKey] = privateKey
+		.split('-----')
+		.filter((item) => item !== '');
+
+	return `-----${openSshKey}-----\n${bodySshKey.replace(/ /g, '\n')}\n-----${endSshKey}-----`;
+}
+
 export class Ssh implements INodeType {
 	description: INodeTypeDescription = {
 		displayName: 'SSH',
@@ -76,6 +84,7 @@ export class Ssh implements INodeType {
 			{
 				name: 'sshPrivateKey',
 				required: true,
+				testedBy: 'sshConnectionTest',
 				displayOptions: {
 					show: {
 						authentication: ['privateKey'],
@@ -297,7 +306,7 @@ export class Ssh implements INodeType {
 					} else {
 						const { path } = await tmpFile({ prefix: 'n8n-ssh-' });
 						temporaryFiles.push(path);
-						await writeFile(path, credentials.privateKey as string);
+						await writeFile(path, sanitizePrivateKey(credentials.privateKey as string));
 
 						const options: Config = {
 							host: credentials.host as string,
@@ -358,7 +367,7 @@ export class Ssh implements INodeType {
 
 				const { path } = await tmpFile({ prefix: 'n8n-ssh-' });
 				temporaryFiles.push(path);
-				await writeFile(path, credentials.privateKey as string);
+				await writeFile(path, sanitizePrivateKey(credentials.privateKey as string));
 
 				const options: Config = {
 					host: credentials.host as string,