Skip to content

Commit

Permalink
feat(editor): Update copy: Execute --> Test (#8137)
Browse files Browse the repository at this point in the history
## Summary

Title self explanatory


## Related tickets and issues
https://linear.app/n8n/issue/ADO-129/update-copy-execute-test

## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
  • Loading branch information
RicardoE105 committed Jan 5, 2024
1 parent 2d6e406 commit df5d07b
Show file tree
Hide file tree
Showing 28 changed files with 64 additions and 72 deletions.
2 changes: 1 addition & 1 deletion cypress/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const INSTANCE_MEMBERS = [
];

export const MANUAL_TRIGGER_NODE_NAME = 'Manual Trigger';
export const MANUAL_TRIGGER_NODE_DISPLAY_NAME = 'When clicking "Execute Workflow"';
export const MANUAL_TRIGGER_NODE_DISPLAY_NAME = 'When clicking "Test Workflow"';
export const MANUAL_CHAT_TRIGGER_NODE_NAME = 'Manual Chat Trigger';
export const SCHEDULE_TRIGGER_NODE_NAME = 'Schedule Trigger';
export const CODE_NODE_NAME = 'Code';
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/13-pinning.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ describe('Data pinning', () => {
});

function setExpressionOnStringValueInSet(expression: string) {
cy.get('button').contains('Execute node').click();
cy.get('button').contains('Test step').click();
cy.get('.fixed-collection-parameter > :nth-child(2) > .button > span').click();

ndv.getters.nthParam(4).contains('Expression').invoke('show').click();
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/4-node-creator.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ describe('Node Creator', () => {
nodeCreatorFeature.getters.getCategoryItem('Actions').click();
nodeCreatorFeature.getters.getCreatorItem('Create a credential').click();
NDVModal.actions.close();
WorkflowPage.actions.deleteNode('When clicking "Execute Workflow"');
WorkflowPage.actions.deleteNode('When clicking "Test Workflow"');
WorkflowPage.getters.canvasNodePlusEndpointByName('n8n').click();
nodeCreatorFeature.getters.searchBar().find('input').clear().type('n8n');
nodeCreatorFeature.getters.getCreatorItem('n8n').click();
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/5-ndv.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ describe('NDV', () => {
ndv.getters.backToCanvas().click();
workflowPage.actions.executeWorkflow();
// Manual tigger node should show success indicator
workflowPage.actions.openNode('When clicking "Execute Workflow"');
workflowPage.actions.openNode('When clicking "Test Workflow"');
ndv.getters.nodeRunSuccessIndicator().should('exist');
// Code node should show error
ndv.getters.backToCanvas().click();
Expand Down
4 changes: 2 additions & 2 deletions cypress/fixtures/Floating_Nodes.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
"parameters": {},
"id": "d0eda550-2526-42a1-aa19-dee411c8acf9",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -91,7 +91,7 @@
],
"pinData": {},
"connections": {
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down
4 changes: 2 additions & 2 deletions cypress/fixtures/Lots_of_nodes.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
"parameters": {},
"id": "369fe424-dd3b-4399-9de3-50bd4ce1f75b",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -570,7 +570,7 @@
],
"pinData": {},
"connections": {
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down
6 changes: 3 additions & 3 deletions cypress/fixtures/Node_IO_filter.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
"parameters": {},
"id": "46770685-44d1-4aad-9107-1d790cf26b50",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -74,7 +74,7 @@
}
],
"pinData": {
"When clicking \"Execute Workflow\"": [
"When clicking \"Test Workflow\"": [
{
"json": {
"id": "654cfa05fa51480dcb543b1a",
Expand Down Expand Up @@ -599,7 +599,7 @@
]
},
"connections": {
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down
16 changes: 8 additions & 8 deletions cypress/fixtures/Suggested_Templates.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
{
"parameters": {},
"id": "551313bb-1e01-4133-9956-e6f09968f2ce",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -92,7 +92,7 @@
}
],
"connections": {
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down Expand Up @@ -191,7 +191,7 @@
{
"parameters": {},
"id": "551313bb-1e01-4133-9956-e6f09968f2ce",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -241,7 +241,7 @@
}
],
"connections": {
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down Expand Up @@ -374,7 +374,7 @@
{
"parameters": {},
"id": "551313bb-1e01-4133-9956-e6f09968f2ce",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -424,7 +424,7 @@
}
],
"connections": {
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down Expand Up @@ -524,7 +524,7 @@
{
"parameters": {},
"id": "551313bb-1e01-4133-9956-e6f09968f2ce",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -574,7 +574,7 @@
}
],
"connections": {
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down
4 changes: 2 additions & 2 deletions cypress/fixtures/Test_workflow_5.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
{
"parameters": {},
"id": "ef63cdc5-50bc-4525-9873-7e7f7589a60e",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -199,7 +199,7 @@
]
]
},
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down
4 changes: 2 additions & 2 deletions cypress/fixtures/Test_workflow_filter.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
"parameters": {},
"id": "f332a7d1-31b4-4e78-b31e-9e8db945bf3f",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -99,7 +99,7 @@
],
"pinData": {},
"connections": {
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down
2 changes: 1 addition & 1 deletion cypress/fixtures/Test_workflow_ndv_version.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
"parameters": {},
"id": "aadaed66-84ed-4cf8-bf21-082e9a65db76",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down
4 changes: 2 additions & 2 deletions cypress/fixtures/Test_workflow_schema_test.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
{
"parameters": {},
"id": "58512a93-dabf-4584-817f-27c608c1bdd5",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand All @@ -69,7 +69,7 @@
]
]
},
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down
4 changes: 2 additions & 2 deletions cypress/fixtures/Test_workflow_schema_test_pinned_data.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
{
"parameters": {},
"id": "3dc7cf26-ff25-4437-b9fd-0e8b127ebec9",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -552,7 +552,7 @@
]
]
},
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down
6 changes: 3 additions & 3 deletions cypress/fixtures/Test_workflow_webhook_with_pin_data.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
"parameters": {},
"id": "0a60e507-7f34-41c0-a0f9-697d852033b6",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -93,7 +93,7 @@
]
},
"connections": {
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down Expand Up @@ -148,4 +148,4 @@
"instanceId": "021d3c82ba2d3bc090cbf4fc81c9312668bcc34297e022bb3438c5c88a43a5ff"
},
"tags": []
}
}
6 changes: 3 additions & 3 deletions cypress/fixtures/Test_workflow_xml_output.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"parameters": {},
"id": "8108d313-8b03-4aa4-963d-cd1c0fe8f85c",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -37,7 +37,7 @@
}
],
"connections": {
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand All @@ -50,4 +50,4 @@
}
},
"pinData": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"parameters": {},
"id": "bcb6abdf-d34b-4ea7-a8ed-58155b708c43",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -90,7 +90,7 @@
}
],
"connections": {
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down
4 changes: 2 additions & 2 deletions cypress/fixtures/workflow-with-unknown-credentials.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
{
"parameters": {},
"id": "acdd1bdc-c642-4ea6-ad67-f4201b640cfa",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand All @@ -37,7 +37,7 @@
}
],
"connections": {
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down
4 changes: 2 additions & 2 deletions cypress/fixtures/workflow-with-unknown-nodes.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"parameters": {},
"id": "40720511-19b6-4421-bdb0-3fb6efef4bc5",
"name": "When clicking \"Execute Workflow\"",
"name": "When clicking \"Test Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
Expand Down Expand Up @@ -64,7 +64,7 @@
}
],
"connections": {
"When clicking \"Execute Workflow\"": {
"When clicking \"Test Workflow\"": {
"main": [
[
{
Expand Down
2 changes: 1 addition & 1 deletion packages/editor-ui/src/components/Node.vue
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
text
icon="play"
:disabled="workflowRunning || isConfigNode"
:title="$locale.baseText('node.executeNode')"
:title="$locale.baseText('node.testStep')"
@click="executeNode"
/>
<n8n-icon-button
Expand Down
14 changes: 3 additions & 11 deletions packages/editor-ui/src/components/NodeExecuteButton.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@
:label="buttonLabel"
:type="type"
:size="size"
:icon="isFormTriggerNode && 'flask'"
:icon="!isListeningForEvents && 'flask'"
:transparent-background="transparent"
@click="onClick"
:title="!isTriggerNode ? $locale.baseText('ndv.execute.testNode.description') : ''"
/>
</div>
</n8n-tooltip>
Expand Down Expand Up @@ -197,16 +198,7 @@ export default defineComponent({
return this.$locale.baseText('ndv.execute.fetchEvent');
}
if (
this.isTriggerNode &&
!this.isScheduleTrigger &&
!this.isManualTriggerNode &&
!this.isFormTriggerNode
) {
return this.$locale.baseText('ndv.execute.listenForEvent');
}
return this.$locale.baseText('ndv.execute.executeNode');
return this.$locale.baseText('ndv.execute.testNode');
},
},
methods: {
Expand Down
Loading

0 comments on commit df5d07b

Please sign in to comment.