Skip to content

Commit

Permalink
fix(Set Node): Increase search priority (#7358)
Browse files Browse the repository at this point in the history
Github issue / Community forum post (link here to close automatically):
  • Loading branch information
michael-radency committed Oct 5, 2023
1 parent afbf0c3 commit e5ad1e7
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 8 deletions.
24 changes: 18 additions & 6 deletions cypress/e2e/4-node-creator.cy.ts
Expand Up @@ -15,7 +15,10 @@ describe('Node Creator', () => {
it('should open node creator on trigger tab if no trigger is on canvas', () => {
nodeCreatorFeature.getters.canvasAddButton().click();

nodeCreatorFeature.getters.nodeCreator().contains('What triggers this workflow?').should('be.visible');
nodeCreatorFeature.getters
.nodeCreator()
.contains('What triggers this workflow?')
.should('be.visible');
});

it('should navigate subcategory', () => {
Expand Down Expand Up @@ -73,7 +76,10 @@ describe('Node Creator', () => {
nodeCreatorFeature.getters.nodeCreator().contains('What happens next?').should('be.visible');

nodeCreatorFeature.getters.getCreatorItem('Add another trigger').click();
nodeCreatorFeature.getters.nodeCreator().contains('What triggers this workflow?').should('be.visible');
nodeCreatorFeature.getters
.nodeCreator()
.contains('What triggers this workflow?')
.should('be.visible');
nodeCreatorFeature.getters.activeSubcategory().find('button').should('exist');
nodeCreatorFeature.getters.activeSubcategory().find('button').click();
nodeCreatorFeature.getters.nodeCreator().contains('What happens next?').should('be.visible');
Expand Down Expand Up @@ -321,15 +327,15 @@ describe('Node Creator', () => {
nodeCreatorFeature.getters.searchBar().find('input').clear().type('email');
nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'Email Trigger (IMAP)');

nodeCreatorFeature.getters.searchBar().find('input').clear().type('Edit Fields (Set)');
nodeCreatorFeature.getters.searchBar().find('input').clear().type('Set');
nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'Edit Fields (Set)');

nodeCreatorFeature.getters.searchBar().find('input').clear().type('i');
nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'IF');
nodeCreatorFeature.getters.nodeItemName().eq(1).should('have.text', 'Switch');

nodeCreatorFeature.getters.searchBar().find('input').clear().type('sw');
nodeCreatorFeature.getters.searchBar().find('input').clear().type('Edit Fields (Set)');
nodeCreatorFeature.getters.searchBar().find('input').clear().type('Edit F');
nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'Edit Fields (Set)');

nodeCreatorFeature.getters.searchBar().find('input').clear().type('i');
Expand Down Expand Up @@ -422,10 +428,16 @@ describe('Node Creator', () => {
nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'S3');

nodeCreatorFeature.getters.searchBar().find('input').clear().type('no op');
nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'No Operation, do nothing');
nodeCreatorFeature.getters
.nodeItemName()
.first()
.should('have.text', 'No Operation, do nothing');

nodeCreatorFeature.getters.searchBar().find('input').clear().type('do no');
nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'No Operation, do nothing');
nodeCreatorFeature.getters
.nodeItemName()
.first()
.should('have.text', 'No Operation, do nothing');

nodeCreatorFeature.getters.searchBar().find('input').clear().type('htt');
nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'HTTP Request');
Expand Down
Expand Up @@ -13,5 +13,5 @@
}
]
},
"alias": ["Filter", "Set", "Data"]
"alias": ["Filter", "_Set", "Data"]
}
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Set/Set.node.json
Expand Up @@ -121,7 +121,7 @@
}
]
},
"alias": ["JSON", "Filter", "Transform", "Map", "Set"],
"alias": ["Set", "JSON", "Filter", "Transform", "Map"],
"subcategories": {
"Core Nodes": ["Data Transformation"]
}
Expand Down

0 comments on commit e5ad1e7

Please sign in to comment.