Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS Node doesn't work when feed has HTML in the description #1133

Closed
karllhughes opened this issue Nov 6, 2020 · 3 comments
Closed

RSS Node doesn't work when feed has HTML in the description #1133

karllhughes opened this issue Nov 6, 2020 · 3 comments

Comments

@karllhughes
Copy link

Describe the bug
I created an RSS node that reads the CircleCI blog RSS feed.

It fails with the following error:

ERROR: Attribute without value Line: 139 Column: 147 Char: >
Error: Attribute without value
Line: 139
Column: 147
Char: >
    at error (/var/www/html/node_modules/sax/lib/sax.js:651:10)
    at strictFail (/var/www/html/node_modules/sax/lib/sax.js:677:7)
    at SAXParser.write (/var/www/html/node_modules/sax/lib/sax.js:1321:13)
    at Parser.exports.Parser.Parser.parseString (/var/www/html/node_modules/xml2js/lib/parser.js:323:31)
    at Parser.parseString (/var/www/html/node_modules/xml2js/lib/parser.js:5:59)
    at /var/www/html/node_modules/rss-parser/lib/parser.js:33:22
    at new Promise (<anonymous>)
    at Parser.parseString (/var/www/html/node_modules/rss-parser/lib/parser.js:32:16)
    at IncomingMessage.<anonymous> (/var/www/html/node_modules/rss-parser/lib/parser.js:96:23)
    at IncomingMessage.emit (events.js:327:22)

I've been parsing a number of feeds successfully, but this one is the first one with HTML elements in the description of the field, so my feeling is that might be the issue.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new RSS node in n8n
  2. Enter this feed: https://circleci.com/blog/feed.xml
  3. Click "Execute node"
  4. The error will show you that the feed parsing failed (see above)

Expected behavior
HTML in a feed is pretty typical, so I would expect this to parse.

Environment (please complete the following information):

  • OS: Ubuntu Linux 18.04
  • n8n Version 0.90.0
  • Node.js Version 12
@janober
Copy link
Member

janober commented Nov 6, 2020

I just tested and it works fine for me.

Expect that the error message is correct and that the XML was maybe not valid at the time you did test and that is why it did error.

@janober janober closed this as completed Nov 6, 2020
@karllhughes
Copy link
Author

Ok, will test more and see if I can reproduce it. Thanks!

@janober
Copy link
Member

janober commented Nov 7, 2020

Yes, thanks. That would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants