Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Do not remove empty output connections arrays in PurgeInvalidWorkflowConnections migration #5546

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

OlegIvaniv
Copy link
Contributor

The PurgeInvalidWorkflowConnections migration filters out empty output connections. This is not required and leads to a migration where nodes with multiple outputs(switch/if) might get indexes mixed up.

Github issue / Community forum post (link here to close automatically):

@OlegIvaniv OlegIvaniv self-assigned this Feb 22, 2023
@OlegIvaniv OlegIvaniv changed the title fix(cli): Do not remove empty output connections arrays in PurgeInvalidWorkflowConnections migration fix(core): Do not remove empty output connections arrays in PurgeInvalidWorkflowConnections migration Feb 22, 2023
@OlegIvaniv OlegIvaniv added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Feb 22, 2023
@OlegIvaniv OlegIvaniv merged commit 0fbb3f0 into master Feb 22, 2023
@OlegIvaniv OlegIvaniv deleted the ado-389-switch-node-outgoing-connections-change branch February 22, 2023 13:20
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Feb 22, 2023
netroy pushed a commit to netroy/n8n that referenced this pull request Feb 23, 2023
…lidWorkflowConnections migration (n8n-io#5546)

fix(cli): Do not remove empty output connections arrays in PurgeInvalidWorkflowConnections migration
netroy pushed a commit that referenced this pull request Feb 23, 2023
…lidWorkflowConnections migration (#5546)

fix(cli): Do not remove empty output connections arrays in PurgeInvalidWorkflowConnections migration
netroy pushed a commit that referenced this pull request Feb 23, 2023
…lidWorkflowConnections migration (#5546)

fix(cli): Do not remove empty output connections arrays in PurgeInvalidWorkflowConnections migration
MiloradFilipovic added a commit that referenced this pull request Feb 23, 2023
* master: (37 commits)
  feat: Migrate packages from lodash to lodash-es (no-changelog) (#5538)
  fix(editor): Apply correct IRunExecutionData to finished workflow (#5552)
  feat: Check new n8n version at start (no-changelog) (#5542)
  fix(editor): Remove 'crashed' status from filter (#5524)
  fix(editor): Fix an issue with zoom and canvas nodes connections (#5548)
  fix(Google Calendar Node): Fix incorrect labels for start and end times when getting all events (#5529)
  fix: fix typo in error messages when a property does not exist (#4310)
  feat: Hide sensible value in Auth Header Credentials and Auth Query Credentials (#5534)
  refactor(WhatsApp Node): Avoid using BinaryDataManager directly from n8n-core (#5544)
  fix(Discord Node): Fix wrong error message being displayed (#5547)
  fix(core): Do not remove empty output connections arrays in PurgeInvalidWorkflowConnections migration (#5546)
  ci: Check PR title on all branches, except release branches (no-changelog) (#5545)
  fix(core): Fix execution status filters (#5533)
  refactor(core): Use an IoC container to manage singleton classes [Part-1] (no-changelog) (#5509)
  ci: Merge back released tag to master as Jan (no-changelog) (#5540)
  fix(Discourse Node): Fix issue with credential test not working (#5520)
  ci: Release process improvements (no-changelog) (#5535)
  feat: Add Required path name mapping to multiple nodes (#5369)
  fix(Compare Datasets Node): UI tweaks and fixes
  feat: Add new event hooks (#5530)
  ...
@janober
Copy link
Member

janober commented Feb 24, 2023

Got released with n8n@0.217.1

@janober janober removed the Upcoming Release Will be part of the upcoming release label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants