Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): SSO onboarding #5756

Merged
merged 5 commits into from
Apr 4, 2023
Merged

feat(editor): SSO onboarding #5756

merged 5 commits into from
Apr 4, 2023

Conversation

cstuncsik
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Mar 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 69.04% and project coverage change: +0.01 🎉

Comparison is base (a721734) 17.49% compared to head (16e9b91) 17.51%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5756      +/-   ##
==========================================
+ Coverage   17.49%   17.51%   +0.01%     
==========================================
  Files        2495     2495              
  Lines      114214   114255      +41     
  Branches    17843    17843              
==========================================
+ Hits        19979    20007      +28     
- Misses      93644    93657      +13     
  Partials      591      591
Impacted Files Coverage Δ
packages/editor-ui/src/stores/sso.ts 71.42% <54.54%> (-2.55%) ⬇️
packages/editor-ui/src/router.ts 87.70% <72.41%> (-0.63%) ⬇️
packages/cli/src/sso/saml/constants.ts 100.00% <100.00%> (ø)
packages/editor-ui/src/constants.ts 97.80% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 22, 2023
@krynble
Copy link
Contributor

krynble commented Apr 4, 2023

Is this PR valid or should we close it @cstuncsik ?

@cstuncsik
Copy link
Contributor Author

It's valid, going to finish it today

@cstuncsik
fix(editor): add SAML onboarding page
657cc27
@cstuncsik
fix(editor): submit user name on SAML onboarding
9e5a552
@cstuncsik
Merge remote-tracking branch 'origin/master' into pay-181-saml-onboar…
16e9b91 
…ding

# Conflicts:
#	packages/editor-ui/src/constants.ts
#	packages/editor-ui/src/router.ts
#	packages/editor-ui/src/stores/sso.ts
@cstuncsik cstuncsik marked this pull request as ready for review April 4, 2023 12:50
flipswitchingmonkey
flipswitchingmonkey reviewed Apr 4, 2023
View reviewed changes
packages/editor-ui/src/stores/sso.ts
@@ -58,6 +61,13 @@ export const useSSOStore = defineStore('sso', () => {
ssoApi.saveSamlConfig(rootStore.getRestApiContext, config);
const testSamlConfig = () => ssoApi.testSamlConfig(rootStore.getRestApiContext);

const updateUser = async (params: { firstName: string; lastName: string }) =>
updateCurrentUser(rootStore.getRestApiContext, {
id: usersStore.currentUser!.id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to send this request without id and email? since the SAML user can't update those?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I have seen it in the me controller it throws only if the current and the request email are different (also if there is no email at all)
Maybe we should introduce a new REST path just for the onboarding

@cstuncsik cstuncsik merged commit 04f8600 into master Apr 4, 2023
@cstuncsik cstuncsik deleted the pay-181-saml-onboarding branch April 4, 2023 16:18
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with n8n@0.223.0

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@cstuncsik @sunilrr
feat(editor): SSO onboarding (n8n-io#5756)
e468d78 
* feat(editor): SSO onboarding

* fix(editor): add SAML onboarding page

* fix(editor): submit user name on SAML onboarding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flipswitchingmonkey flipswitchingmonkey flipswitchingmonkey approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cstuncsik @krynble @janober @flipswitchingmonkey