-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): SSO onboarding #5756
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5756 +/- ##
==========================================
+ Coverage 17.49% 17.51% +0.01%
==========================================
Files 2495 2495
Lines 114214 114255 +41
Branches 17843 17843
==========================================
+ Hits 19979 20007 +28
- Misses 93644 93657 +13
Partials 591 591
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Is this PR valid or should we close it @cstuncsik ? |
It's valid, going to finish it today |
…ding # Conflicts: # packages/editor-ui/src/constants.ts # packages/editor-ui/src/router.ts # packages/editor-ui/src/stores/sso.ts
@@ -58,6 +61,13 @@ export const useSSOStore = defineStore('sso', () => { | |||
ssoApi.saveSamlConfig(rootStore.getRestApiContext, config); | |||
const testSamlConfig = () => ssoApi.testSamlConfig(rootStore.getRestApiContext); | |||
|
|||
const updateUser = async (params: { firstName: string; lastName: string }) => | |||
updateCurrentUser(rootStore.getRestApiContext, { | |||
id: usersStore.currentUser!.id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to send this request without id and email? since the SAML user can't update those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I have seen it in the me
controller it throws only if the current and the request email are different (also if there is no email at all)
Maybe we should introduce a new REST path just for the onboarding
Got released with |
* feat(editor): SSO onboarding * fix(editor): add SAML onboarding page * fix(editor): submit user name on SAML onboarding
Github issue / Community forum post (link here to close automatically):