Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix issue preventing execution preview loading when in an iframe #5817

Merged
merged 5 commits into from Mar 30, 2023

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Mar 29, 2023

Github issue / Community forum post (link here to close automatically): #5584

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 29, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/editor-ui/src/views/NodeView.vue:

  • Avoided adding code here. Only refactored to make it smaller.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (9e9003b) 14.83% compared to head (30f9a9c) 14.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5817   +/-   ##
=======================================
  Coverage   14.83%   14.83%           
=======================================
  Files        2475     2475           
  Lines      113363   113367    +4     
  Branches    17702    17703    +1     
=======================================
+ Hits        16820    16823    +3     
  Misses      95999    95999           
- Partials      544      545    +1     
Impacted Files Coverage Δ
...es/cli/src/controllers/passwordReset.controller.ts 85.05% <75.00%> (-0.49%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Joffcom Joffcom merged commit d86e693 into master Mar 30, 2023
10 checks passed
@Joffcom Joffcom deleted the n8n-6216-from-github-execution-preview-is-not branch March 30, 2023 11:17
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 30, 2023
believe-Mahesh pushed a commit to believe-Mahesh/n8n that referenced this pull request Apr 4, 2023
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with n8n@0.223.0

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants