Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add color picker design system component #6179

Merged
merged 13 commits into from
May 11, 2023

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/design-system/**/*.vue:

  • Used design system tokens (colors, spacings...) where possible.
  • Updated Storybook with new component or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (06948b5) 19.93% compared to head (f222205) 19.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6179      +/-   ##
==========================================
- Coverage   19.93%   19.93%   -0.01%     
==========================================
  Files        2646     2649       +3     
  Lines      119664   119733      +69     
  Branches    18929    18930       +1     
==========================================
+ Hits        23859    23866       +7     
- Misses      95078    95140      +62     
  Partials      727      727              
Impacted Files Coverage Δ
...c/components/N8nColorPicker/ColorPicker.stories.ts 0.00% <0.00%> (ø)
...sign-system/src/components/N8nColorPicker/index.ts 0.00% <0.00%> (ø)
packages/design-system/src/components/index.ts 0.00% <0.00%> (ø)
packages/design-system/src/plugin.ts 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 823e885 into master May 11, 2023
@cstuncsik cstuncsik deleted the pay-430-create-n8n-color-picker-design-system branch May 11, 2023 13:28
MiloradFilipovic added a commit that referenced this pull request May 12, 2023
* master:
  feat(editor): Version Control settings update (WIP) (#6233)
  ci: Fix linting issue on master (no-changelog) (#6232)
  fix: Prevent type error messages for manual executions (no-changelog) (#6229)
  fix(Code Node): Restore help text (#6231)
  fix(core): Make sure that special polling parameters are available on community nodes as well (#6230)
  feat(editor): Add color picker design system component (#6179)
  feat(Google Ads Node): Update to support v13 (#6212)
  ci: Fix published nodes-base package's dependencies (no-changelog) (#6226)
  ci: Code coverage should include `.vue` files as well (no-changelog) (#6224)
  🚀 Release 0.228.0 (#6219)
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.230.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants