Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Code coverage should include .vue files as well (no-changelog) #6224

Merged
merged 1 commit into from
May 11, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented May 11, 2023

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +7.65 🎉

Comparison is base (c42ae65) 19.94% compared to head (9e36385) 27.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6224      +/-   ##
==========================================
+ Coverage   19.94%   27.59%   +7.65%     
==========================================
  Files        2651     2935     +284     
  Lines      119713   179761   +60048     
  Branches    18932    19538     +606     
==========================================
+ Hits        23880    49612   +25732     
- Misses      95106   129418   +34312     
- Partials      727      731       +4     

see 284 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 11, 2023
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 8268790 into master May 11, 2023
22 checks passed
@netroy netroy deleted the codecov-include-vue-files branch May 11, 2023 10:29
MiloradFilipovic added a commit that referenced this pull request May 11, 2023
* master:
  feat(Google Ads Node): Update to support v13 (#6212)
  ci: Fix published nodes-base package's dependencies (no-changelog) (#6226)
  ci: Code coverage should include `.vue` files as well (no-changelog) (#6224)
  🚀 Release 0.228.0 (#6219)
  ci: Fix linting issue on master (no-changelog) (#6222)
  fix(core): Ensure DB repositories are initialized before the DB migrations are run  (#6220)
  refactor(editor): Stricter linting for promises and async functions (no-changelog) (#4642)
  ci: Increase timeout for DB tests (no-changelog) (#6221)
  fix(editor): Fix viewing and downloading of binary data (#6218)
  fix: Prevent unnecessary error messages also for data loaded flag (#6201)
  feat: Create NPM node (#6177)
  fix(editor): Fix polling trigger check for `runData` (#6130)
  ci: Fix linting issue on master (no-changelog) (#6217)
  fix: Prevent overflow when rendering expression hints (#6214)
  feat(core): Improve health check (#6205)
  refactor(editor): Add GitHub 30k stars banner (no-changelog) (#6204)
  fix(editor): Add loading skeletons to Executions list page (#6184)
  ci: Fix v1 docker rc builds (no-changelog) (#6208)
  feat(Code Node): Set `defaultVersion` to 2 for V1 RC builds (no-changelog) (#6209)
  fix: Correctly save executions that failed when polling as error instead of new (#6192)

# Conflicts:
#	packages/editor-ui/src/components/ParameterInputList.vue
MiloradFilipovic added a commit that referenced this pull request May 12, 2023
* master:
  feat(editor): Version Control settings update (WIP) (#6233)
  ci: Fix linting issue on master (no-changelog) (#6232)
  fix: Prevent type error messages for manual executions (no-changelog) (#6229)
  fix(Code Node): Restore help text (#6231)
  fix(core): Make sure that special polling parameters are available on community nodes as well (#6230)
  feat(editor): Add color picker design system component (#6179)
  feat(Google Ads Node): Update to support v13 (#6212)
  ci: Fix published nodes-base package's dependencies (no-changelog) (#6226)
  ci: Code coverage should include `.vue` files as well (no-changelog) (#6224)
  🚀 Release 0.228.0 (#6219)
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.230.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants