Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OpenAI Node): Descriptive errors #6270

Merged

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency commented May 18, 2023

Github issue / Community forum post (link here to close automatically):#6270

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels May 18, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (4219490) 27.69% compared to head (24e224a) 27.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6270      +/-   ##
==========================================
- Coverage   27.69%   27.69%   -0.01%     
==========================================
  Files        2947     2948       +1     
  Lines      180861   180869       +8     
  Branches    19634    19635       +1     
==========================================
  Hits        50090    50090              
- Misses     130026   130034       +8     
  Partials      745      745              
Impacted Files Coverage Δ
...ackages/nodes-base/nodes/OpenAi/ChatDescription.ts 0.00% <0.00%> (ø)
...ckages/nodes-base/nodes/OpenAi/GenericFunctions.ts 0.00% <0.00%> (ø)
...ckages/nodes-base/nodes/OpenAi/ImageDescription.ts 0.00% <0.00%> (ø)
packages/nodes-base/nodes/OpenAi/OpenAi.node.ts 0.00% <ø> (ø)
...ackages/nodes-base/nodes/OpenAi/TextDescription.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Joffcom Joffcom mentioned this pull request May 18, 2023
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 8fdfa3b into master May 18, 2023
24 of 25 checks passed
@michael-radency michael-radency deleted the node-512-openai-api-errors-arent-shown-in-the-ui branch May 18, 2023 14:20
MiloradFilipovic added a commit that referenced this pull request May 19, 2023
* master:
  fix(Google Calendar Node): All day option fix (#6274)
  feat(Gotify Node): Add support for self signed certificates (#6053)
  docs: Remove missed beta text from Notion node (no-changelog) (#6166)
  fix(OpenAI Node): Descriptive errors (#6270)
  fix(SSH Node): Replace ~ with /home/username (#6269)
  feat(core): Replace client-oauth2 with an in-repo package (#6266)
  🚀 Release 0.229.0 (#6267)
  fix: Revert "Replace client-oauth2 with an in-repo package" (no-changelog) (#6265)
  feat(Respond to Webhook Node): Move from Binary Buffer to Binary streaming (#5613)
  feat(core): Replace client-oauth2 with an in-repo package (#6056)
  fix(editor): Fix typo and change text sizes in ExecutionUsage component (no-changelog) (#6261)
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.230.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants