Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove missed beta text from Notion node (no-changelog) #6166

Merged
merged 2 commits into from
May 18, 2023

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented May 3, 2023

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cd7c312) 27.50% compared to head (3b95ac4) 27.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6166   +/-   ##
=======================================
  Coverage   27.50%   27.50%           
=======================================
  Files        2940     2940           
  Lines      180626   180626           
  Branches    19563    19563           
=======================================
  Hits        49681    49681           
  Misses     130211   130211           
  Partials      734      734           
Impacted Files Coverage Δ
...ages/nodes-base/nodes/Notion/NotionTrigger.node.ts 0.00% <ø> (ø)
...s/nodes-base/nodes/Notion/v1/VersionDescription.ts 0.00% <ø> (ø)
...s/nodes-base/nodes/Notion/v2/VersionDescription.ts 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@agobrech agobrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 000cacf into master May 18, 2023
@Joffcom Joffcom deleted the notion-beta-label branch May 18, 2023 16:33
MiloradFilipovic added a commit that referenced this pull request May 19, 2023
* master:
  fix(Google Calendar Node): All day option fix (#6274)
  feat(Gotify Node): Add support for self signed certificates (#6053)
  docs: Remove missed beta text from Notion node (no-changelog) (#6166)
  fix(OpenAI Node): Descriptive errors (#6270)
  fix(SSH Node): Replace ~ with /home/username (#6269)
  feat(core): Replace client-oauth2 with an in-repo package (#6266)
  🚀 Release 0.229.0 (#6267)
  fix: Revert "Replace client-oauth2 with an in-repo package" (no-changelog) (#6265)
  feat(Respond to Webhook Node): Move from Binary Buffer to Binary streaming (#5613)
  feat(core): Replace client-oauth2 with an in-repo package (#6056)
  fix(editor): Fix typo and change text sizes in ExecutionUsage component (no-changelog) (#6261)
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.230.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants