Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Remove all floating promises. Enforce @typescript-eslint/no-floating-promises #6281

Merged
merged 1 commit into from
May 24, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented May 19, 2023

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 7.14% and no project coverage change.

Comparison is base (3750605) 27.65% compared to head (0b29626) 27.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6281   +/-   ##
=======================================
  Coverage   27.65%   27.65%           
=======================================
  Files        2948     2948           
  Lines      180860   180860           
  Branches    19641    19642    +1     
=======================================
  Hits        50019    50019           
  Misses     130094   130094           
  Partials      747      747           
Impacted Files Coverage Δ
packages/cli/src/ActiveWorkflowRunner.ts 45.48% <0.00%> (ø)
packages/cli/src/Server.ts 0.00% <0.00%> (ø)
packages/cli/src/TestWebhooks.ts 9.47% <0.00%> (ø)
packages/cli/src/WaitTracker.ts 0.00% <0.00%> (ø)
packages/cli/src/WaitingWebhooks.ts 0.00% <0.00%> (ø)
packages/cli/src/WorkflowRunner.ts 9.74% <0.00%> (+0.03%) ⬆️
packages/cli/src/WorkflowRunnerProcess.ts 0.00% <0.00%> (ø)
packages/cli/src/commands/start.ts 0.00% <0.00%> (ø)
packages/cli/src/commands/worker.ts 0.00% <0.00%> (ø)
packages/cli/src/middlewares/basicAuth.ts 67.85% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems all right, tested running n8n, running some workflows, manual executions, multiple types of triggers and activation and deactivation of workflows. Everything seems fine.

LGTM.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit e046f65 into master May 24, 2023
22 checks passed
@netroy netroy deleted the no-floating-promises branch May 24, 2023 00:01
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.230.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants