fix(editor): Fix canvas loading when page gets restored from bfcache #6304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
mutdmour
previously approved these changes
May 23, 2023
n8n-assistant
bot
added
n8n team
|
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6304 +/- ##
==========================================
- Coverage 27.65% 27.60% -0.05%
==========================================
Files 2948 2957 +9
Lines 180896 181213 +317
Branches 19646 19699 +53
==========================================
+ Hits 50019 50023 +4
- Misses 130130 130443 +313
Partials 747 747
☔ View full report in Codecov by Sentry. |
mutdmour
approved these changes
May 23, 2023
|
|
|
✅ All Cypress E2E specs passed |
eyaljoyous
pushed a commit
to eyaljoyous/n8n
that referenced
this pull request
May 23, 2023
* allow execution on node 19,20,22 * fix(ERPNext Node): Fix issue with credential test and add frappe cloud url (n8n-io#6283) * fix(editor): UI copy fix for Date & Time node (no-changelog) (n8n-io#6291) * whether -> when * lint fix --------- Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com> * feat(RabbitMQ Node): Add mode for acknowledging and deleting from queue later in workflow (n8n-io#6225) * Add later in workflow mode * Add new operation * Acknowledge message in next node * Add response and emit for responsePromiseHook * Remove double success message, close channel correctly * Answser messages correctly * Remove option from delete operation * move operation name to camelCase * Fix versioning * To remove: add action item in v1 * Add notice for delete from queue * Correctly only execute only the delete operation * Refactor delete from queue operator and add return last items --------- Co-authored-by: Marcus <marcus@n8n.io> * feat: Add dangerouslyUseHTMLString where needed (no-changelog) (n8n-io#6292) feat: add dangerouslyUseHTMLString where needed (no-changelog) * fix(Wekan Node): Handle response correctly (n8n-io#6296) Fix bug when response wasn't array * Added procfile * Added procfile * redployed * redployed * redployed * redployed * redployed * redployed * dont start * redployed * redployed * update version * redployed * redployed * redployed * redployed * Revert "update version" This reverts commit c249585. * add heroku stack version * delete * add app.json setting heroku build stack * update * update vite * update mem * update PORT * redployed * fix(core): Optimize SharedWorkflow queries (n8n-io#6297) * optimize SharedWorkflow queries * fix int to string ids * fix(Strapi Node): Strapi credentials notice (n8n-io#6289) * fix(SSH Node): Private key field as password and credential test (n8n-io#6298) * fix: Prevent removing manual executions when setting says to save (n8n-io#6300) * fix: Initialize license in queue mode correctly (n8n-io#6301) * feat(Ldap Node): Add LDAP node (n8n-io#4783) * feat(LoneScale Node): Add LoneScale node and Trigger node (n8n-io#5146) * feat: Add SSO SAML metadataUrl support and various improvements (n8n-io#6139) * feat: add various sso improvements * fix: remove test button assertion * fix: fix type imports * test: attempt fixing unit tests * fix: changed to using useToast for error toasts * Minor copy tweaks and swapped buttons position. * fix locale ref * align error with UI wording * simplify saving ux * fix pretty * fix: update saml sso setting saving * fix: undo try/catch changes when saving saml config * metadata url tab selected at first * chore: fix linting issue * test: fix activation checkbox test --------- Co-authored-by: Giulio Andreini <g.andreini@gmail.com> Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com> Co-authored-by: Romain Minaud <romain.minaud@gmail.com> * fix(editor): Fix canvas loading when page gets restored from bfcache (n8n-io#6304) * fix(editor): Fix canvas loading when page gets restored from bfcache * Lint fix * fix(editor): Link to log streaming doc from log streaming (no-changelog) (n8n-io#6303) link to log streaming doc from log streaming --------- Co-authored-by: Eyal Fishler <eyalfishler@gmail.com> Co-authored-by: Jon <jonathan.bennetts@gmail.com> Co-authored-by: Deborah <deborah@starfallprojects.co.uk> Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com> Co-authored-by: Marcus <marcus@n8n.io> Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: Omri Attoun <omri@joyous.team> Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com> Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com> Co-authored-by: Omar Ajoue <krynble@gmail.com> Co-authored-by: Yann ALEMAN <yann.aleman27@gmail.com> Co-authored-by: Giulio Andreini <g.andreini@gmail.com> Co-authored-by: Romain Minaud <romain.minaud@gmail.com> Co-authored-by: OlegIvaniv <me@olegivaniv.com>
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a problem with the 'beforeunload' event listener on our node view. This feature shows a 'redirecting' loading sign when a user leaves the page. However, if the user is on a browser that supports back-forward cache (like Safari or Chrome), our app stays in memory. This means when they navigate back to the app, it gets stuck in the loading state.
To fix this, we're adding a new event handler for the 'pageshow' event. This handler will check if the page came back from the back-forward cache. If it did, the handler will stop the loading process.
Github issue / Community forum post (link here to close automatically):