fix(editor): Pin all data regardless of pagination #6346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6346 +/- ##
==========================================
+ Coverage 27.66% 28.31% +0.65%
==========================================
Files 2958 2982 +24
Lines 181566 185130 +3564
Branches 19732 20296 +564
==========================================
+ Hits 50225 52425 +2200
- Misses 130593 131920 +1327
- Partials 748 785 +37
☔ View full report in Codecov by Sentry. |
alexgrozav
requested changes
Jun 1, 2023
alexgrozav
approved these changes
Jun 2, 2023
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 2, 2023
* master: fix(editor): Fix hard-coded parameter names for code editors (#6372) ci: Add support for Node.js 18 (#5793) ci: Update the release process for v1 release (#6366) refactor: Add deprecation notice for UM disabled mode (#6367) feat(editor): Make WF name a link on /executions (#6354) ci: Revert "Set up Turborepo cache for GitHub actions runner" (#6364) (no-changelog) fix(editor): Add secondary icon to menu items (#6351) fix(editor): Pin all data regardless of pagination (#6346) feat(Crypto Node): Add support for hash and hmac on binary data (#6359) ci: Set up Turborepo cache for GitHub actions runner (no-changelog) (#6335) # Conflicts: # packages/editor-ui/src/components/ParameterInput.vue
|
Got released with |
netroy
pushed a commit
that referenced
this pull request
Jun 14, 2023
* fix(editor): pin all data * fix(editor): restore pinned data pagination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.