feat(editor): Make WF name a link on /executions #6354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6354 +/- ##
==========================================
- Coverage 28.32% 28.30% -0.02%
==========================================
Files 2982 2982
Lines 185150 185113 -37
Branches 20299 20294 -5
==========================================
- Hits 52447 52403 -44
- Misses 131918 131925 +7
Partials 785 785
☔ View full report in Codecov by Sentry. |
cstuncsik
approved these changes
Jun 1, 2023
|
|
2 similar comments
|
|
|
|
cstuncsik
approved these changes
Jun 1, 2023
|
|
4 similar comments
|
|
|
|
|
|
|
|
…m:n8n-io/n8n into pay-142-make-wf-name-a-link-on-executions
alexgrozav
approved these changes
Jun 2, 2023
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 2, 2023
* master: fix(editor): Fix hard-coded parameter names for code editors (#6372) ci: Add support for Node.js 18 (#5793) ci: Update the release process for v1 release (#6366) refactor: Add deprecation notice for UM disabled mode (#6367) feat(editor): Make WF name a link on /executions (#6354) ci: Revert "Set up Turborepo cache for GitHub actions runner" (#6364) (no-changelog) fix(editor): Add secondary icon to menu items (#6351) fix(editor): Pin all data regardless of pagination (#6346) feat(Crypto Node): Add support for hash and hmac on binary data (#6359) ci: Set up Turborepo cache for GitHub actions runner (no-changelog) (#6335) # Conflicts: # packages/editor-ui/src/components/ParameterInput.vue
ivov
added a commit
that referenced
this pull request
Jun 8, 2023
…ons (#6352) * fix: Unify expression error behavior for v1 * fix: Add `package.json` to `tsconfig.build.json` * fix: Make `isFrontend` a constant * fix: Use CommonJS require to read version * fix: Use `JSON.parse()` and `fs.readFileSync()` * feat(editor): Make WF name a link on /executions (#6354) * make wf name a link in exec view * link color * make wf name a link in exec view * link color --------- Co-authored-by: Alex Grozav <alex@grozav.com> * fix: Try restoring inclusions in tsconfig files * fix: Try with copy * refactor: Switch base branch and remove global toggle * chore: Remove unrelated changes * chore: Restore lockfile * fix: Ensure all expression errors fail executions * uncaught ExpressionErrors should not fail e2e tests --------- Co-authored-by: romainminaud <romain.minaud@gmail.com> Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
|
Got released with |
netroy
added a commit
that referenced
this pull request
Jun 22, 2023
…ons (#6352) * fix: Unify expression error behavior for v1 * fix: Add `package.json` to `tsconfig.build.json` * fix: Make `isFrontend` a constant * fix: Use CommonJS require to read version * fix: Use `JSON.parse()` and `fs.readFileSync()` * feat(editor): Make WF name a link on /executions (#6354) * make wf name a link in exec view * link color * make wf name a link in exec view * link color --------- Co-authored-by: Alex Grozav <alex@grozav.com> * fix: Try restoring inclusions in tsconfig files * fix: Try with copy * refactor: Switch base branch and remove global toggle * chore: Remove unrelated changes * chore: Restore lockfile * fix: Ensure all expression errors fail executions * uncaught ExpressionErrors should not fail e2e tests --------- Co-authored-by: romainminaud <romain.minaud@gmail.com> Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would greatly improve the UX of the exec list view if the WF name text itself was a link that opens the workflow.