fix(core): Change VariablesService to DI and use caching #6827

flipswitchingmonkey · 2023-08-01T14:56:56Z

No description provided.

…or-injection

…or-injection # Conflicts: # packages/cli/src/AbstractServer.ts # packages/cli/src/Queue.ts

…or-injection

…or-injection # Conflicts: # packages/cli/package.json # pnpm-lock.yaml

…or-injection

codecov · 2023-08-01T15:12:13Z

Codecov Report

Patch coverage: 84.74% and no project coverage change.

Comparison is base (3cad60e) 24.76% compared to head (ae8fa2b) 24.76%.
Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6827   +/-   ##
=======================================
  Coverage   24.76%   24.76%           
=======================================
  Files        3131     3131           
  Lines      190781   190809   +28     
  Branches    21011    21012    +1     
=======================================
+ Hits        47239    47261   +22     
- Misses     142588   142592    +4     
- Partials      954      956    +2

Files Changed	Coverage Δ
...ts/sourceControl/sourceControlImport.service.ee.ts	`8.94% <50.00%> (+0.71%)`	⬆️
packages/cli/src/WorkflowHelpers.ts	`48.90% <66.66%> (+0.56%)`	⬆️
...ts/sourceControl/sourceControlExport.service.ee.ts	`16.36% <66.66%> (+0.76%)`	⬆️
...li/src/environments/variables/variables.service.ts	`89.65% <89.28%> (+9.65%)`	⬆️
.../environments/variables/variables.controller.ee.ts	`90.24% <100.00%> (+0.24%)`	⬆️
...src/environments/variables/variables.controller.ts	`87.17% <100.00%> (+0.33%)`	⬆️
...src/environments/variables/variables.service.ee.ts	`96.42% <100.00%> (ø)`

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

valya

Other than the one issue it looks good to me.

packages/cli/test/integration/shared/testDb.ts

… into pay-644-variables-loading-might-be-slow

github-actions · 2023-08-02T10:53:41Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

packages/cli/src/environments/sourceControl/sourceControlImport.service.ee.ts

packages/cli/src/environments/variables/variables.service.ts

done

github-actions · 2023-08-02T11:20:33Z

⚠️ Some Cypress E2E specs are failing, please fix them before merging

cypress · 2023-08-02T11:20:37Z

1 flaky tests on run #1753 ↗︎

0	221	0	0	1

Details:

🌳 pay-644-variables-loading-might-be-slow 🖥️ browsers:node18.12.0-chrome107 🤖...
Project: n8n	Commit: `ae8fa2b2fc`
Status: Passed	Duration: 07:57 💡
Started: Aug 2, 2023 12:39 PM	Ended: Aug 2, 2023 12:47 PM

cypress/e2e/11-inline-expression-editor.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
Inline expression editor > should resolve $parameter[]		`Output` `Screenshots` `Video`

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

github-actions · 2023-08-02T11:26:16Z

✅ All Cypress E2E specs passed

ivov

Approving but ideally let's fix the test in a followup 🙏🏻

ivov

ActiveWorkflowRunner tests are also failing

github-actions · 2023-08-02T12:30:52Z

✅ All Cypress E2E specs passed

ivov

Approving but let's wait for the tests!

github-actions · 2023-08-02T12:47:22Z

✅ All Cypress E2E specs passed

janober · 2023-08-09T17:48:56Z

Got released with n8n@1.2.1

flipswitchingmonkey added 24 commits July 19, 2023 15:25

support redis cluster

765ebd2

cleanup, fix config schema

492e8a6

set default prefix to bull

4d6b64a

Merge branch 'master' into pay-639-make-redis-client-into-a-service-f…

76e1e6b

…or-injection

initial commit

8b924b4

improve logging

9686c8d

improve types and refactor

ffc70dd

list support and refactor

15bb8ca

Merge branch 'master' into pay-639-make-redis-client-into-a-service-f…

ec08e9a

…or-injection # Conflicts: # packages/cli/src/AbstractServer.ts # packages/cli/src/Queue.ts

fix redis service and tests

0e584eb

add comment

1fa934d

add redis and cache prefix

16e2b8a

use injection

364e0ec

lint fix

6bff179

Merge branch 'master' into pay-639-make-redis-client-into-a-service-f…

5bfabdd

…or-injection

clean schema comments

331d433

improve naming, tests, cluster client

f7f83fd

Merge branch 'master' into pay-639-make-redis-client-into-a-service-f…

d56317c

…or-injection # Conflicts: # packages/cli/package.json # pnpm-lock.yaml

merge master

edec7c6

cache returns unknown instead of T

0ced012

update cache service, tests and doc

1a5b761

Merge branch 'master' into pay-639-make-redis-client-into-a-service-f…

86f7eaa

…or-injection

remove console.log

ef7a266

VariablesService as DI, add caching, fix tests

5b85ec0

flipswitchingmonkey requested a review from valya August 1, 2023 14:57

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 1, 2023

do not cache null or undefined values

69dbe17

valya previously requested changes Aug 1, 2023

View reviewed changes

packages/cli/test/integration/shared/testDb.ts Outdated Show resolved Hide resolved

flipswitchingmonkey added 2 commits August 2, 2023 11:22

lint fix

056de7d

Merge branch 'pay-639-make-redis-client-into-a-service-for-injection'…

dc30d03

… into pay-644-variables-loading-might-be-slow

Base automatically changed from pay-639-make-redis-client-into-a-service-for-injection to master August 2, 2023 10:51

Merge branch 'master' into pay-644-variables-loading-might-be-slow

3212d8a

flipswitchingmonkey requested a review from ivov August 2, 2023 10:55

ivov previously approved these changes Aug 2, 2023

View reviewed changes

packages/cli/src/environments/sourceControl/sourceControlImport.service.ee.ts Outdated Show resolved Hide resolved

packages/cli/src/environments/variables/variables.service.ts Outdated Show resolved Hide resolved

rename to ~Cached

8d3b2cb

flipswitchingmonkey dismissed ivov’s stale review via 8d3b2cb August 2, 2023 11:10

flipswitchingmonkey requested a review from ivov August 2, 2023 11:11

ivov previously approved these changes Aug 2, 2023

View reviewed changes

fix test for CI

b15630e

flipswitchingmonkey dismissed ivov’s stale review via b15630e August 2, 2023 11:36

flipswitchingmonkey requested a review from ivov August 2, 2023 11:44

ivov approved these changes Aug 2, 2023

View reviewed changes

ivov requested changes Aug 2, 2023

View reviewed changes

fix ActiveWorkflowRunner test

ae8fa2b

flipswitchingmonkey requested a review from ivov August 2, 2023 12:27

ivov approved these changes Aug 2, 2023

View reviewed changes

flipswitchingmonkey merged commit 659ca26 into master Aug 2, 2023
48 of 49 checks passed

flipswitchingmonkey deleted the pay-644-variables-loading-might-be-slow branch August 2, 2023 12:51

github-actions bot mentioned this pull request Aug 9, 2023

🚀 Release 1.2.0 #6891

Merged

janober added the Released label Aug 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): Change VariablesService to DI and use caching #6827

fix(core): Change VariablesService to DI and use caching #6827

flipswitchingmonkey commented Aug 1, 2023

codecov bot commented Aug 1, 2023 •

edited

Loading

valya left a comment

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

cypress bot commented Aug 2, 2023 •

edited

Loading

github-actions bot commented Aug 2, 2023

ivov left a comment

ivov left a comment

github-actions bot commented Aug 2, 2023

ivov left a comment

github-actions bot commented Aug 2, 2023

janober commented Aug 9, 2023

fix(core): Change VariablesService to DI and use caching #6827

fix(core): Change VariablesService to DI and use caching #6827

Conversation

flipswitchingmonkey commented Aug 1, 2023

codecov bot commented Aug 1, 2023 • edited Loading

Codecov Report

valya left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

cypress bot commented Aug 2, 2023 • edited Loading

1 flaky tests on run #1753 ↗︎

github-actions bot commented Aug 2, 2023

ivov left a comment

Choose a reason for hiding this comment

ivov left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2023

ivov left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2023

janober commented Aug 9, 2023

codecov bot commented Aug 1, 2023 •

edited

Loading

cypress bot commented Aug 2, 2023 •

edited

Loading