Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Change VariablesService to DI and use caching #6827
fix(core): Change VariablesService to DI and use caching #6827
Changes from all commits
765ebd2
492e8a6
4d6b64a
76e1e6b
8b924b4
9686c8d
ffc70dd
15bb8ca
ec08e9a
0e584eb
1fa934d
16e2b8a
364e0ec
6bff179
5bfabdd
331d433
f7f83fd
d56317c
edec7c6
0ced012
1a5b761
86f7eaa
ef7a266
5b85ec0
69dbe17
abbb6f4
d66162c
acbbfdb
659bbe7
2298c3c
056de7d
dc30d03
3212d8a
8d3b2cb
b15630e
ae8fa2b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect
VariablesService
to offercreateVariable()
to take care of creating the var and updating the cache.