Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix workflow history prune time limit (getting hours instead of days) #7644

Conversation

cstuncsik
Copy link
Contributor

No description provided.

Copy link

cypress bot commented Nov 7, 2023

3 flaky tests on run #2761 ↗︎

0 271 0 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: 6da668372e
Status: Passed Duration: 07:32 💡
Started: Nov 7, 2023 4:20 PM Ended: Nov 7, 2023 4:27 PM
Flakiness  6-code-node.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Code node > Code editor > should execute the placeholder successfully in both modes Output Screenshots Video
... > generate code button should have correct state & tooltips Output Screenshots Video
Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Current Workflow Executions > should render executions tab correctly Output Screenshots Video

Review all test suite changes for PR #7644 ↗︎

Copy link
Contributor

github-actions bot commented Nov 7, 2023

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 7, 2023
@cstuncsik cstuncsik merged commit 3d5a485 into master Nov 7, 2023
55 of 56 checks passed
@cstuncsik cstuncsik deleted the pay-989-update-workflow-history-display-message-to-reflect-hours branch November 7, 2023 16:44
MiloradFilipovic added a commit that referenced this pull request Nov 8, 2023
* master: (24 commits)
  fix(Crypto Node): Fix issue with value not appearing for Sign action (#7619)
  feat(NocoDB Node): Add new data apis and workspace support (#7329)
  fix(Facebook Lead Ads Trigger Node): Fix issue with missing scope for business management  (#7616)
  refactor(core): Stop reporting to Sentry missing-node-on-retry error (no-changelog) (#7648)
  fix(editor): Fix workflow history prune time limit (getting hours instead of days) (#7644)
  fix(core): Comply with custom default for workflow saving settings (#7634)
  feat(core): Initial support for two-way communication over websockets (#7570)
  ci: Conditionally re-enable coverage for frontend packages (no-changelog) (#7641)
  ci(core): Load config schema after process.env has been overwritten (no-changelog) (#7550)
  fix(core): Make password-reset urls valid only for single-use (#7622)
  fix: Error handling on forgot password page (no-changelog) (#7633)
  ci: Improve CI performance (no-changelog) (#7637)
  fix(core): Ensure pruning starts only after migrations have completed (#7626)
  feat(core): Coordinate workflow activation in multiple main scenario in internal API (#7566)
  fix(editor): Fix local storage flags defaulting to undefined string (#7603)
  fix(editor): Reset canvas zoom before workspace reset in node view (#7625)
  fix(editor): More dark-mode fixes (no-changelog) (#7624)
  fix(core): Fix accessor error when running partial execution (#7618)
  fix(editor): Fix issue that frontend breaks with unkown nodes (#7596)
  fix(core): Ensure `init` before checking leader or follower in multi-main scenario (#7621)
  ...
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
ivov added a commit that referenced this pull request Nov 8, 2023
#
[1.16.0](https://github.com/n8n-io/n8n/compare/n8n@1.15.1...n8n@1.16.0)
(2023-11-08)


### Bug Fixes

* **core:** Comply with custom default for workflow saving settings
([#7634](#7634))
([48c068f](48c068f))
* **core:** Decrease reset password token expire time
([#7598](#7598))
([2aa7f63](2aa7f63))
* **core:** Ensure `init` before checking leader or follower in
multi-main scenario ([#7621](#7621))
([a994ba5](a994ba5))
* **core:** Ensure pruning starts only after migrations have completed
([#7626](#7626))
([f748de9](f748de9))
* **core:** Fix accessor error when running partial execution
([#7618](#7618))
([26361df](26361df)),
closes [#6229](#6229)
* **core:** Make password-reset urls valid only for single-use
([#7622](#7622))
([6031424](6031424))
* **Crypto Node:** Fix issue with value not appearing for Sign action
([#7619](#7619))
([5df583f](5df583f))
* **editor:** Allow overriding theme from query params
([#7591](#7591))
([2854a0c](2854a0c))
* **editor:** Fix issue that frontend breaks with unkown nodes
([#7596](#7596))
([db56a9e](db56a9e))
* **editor:** Fix local storage flags defaulting to undefined string
([#7603](#7603))
([151e60f](151e60f))
* **editor:** Fix workflow history prune time limit (getting hours
instead of days) ([#7644](#7644))
([3d5a485](3d5a485))
* **editor:** Hide not supported node options
([#7597](#7597))
([b532a7b](b532a7b))
* **editor:** Remove unknown credentials on pasting workflow
([#7582](#7582))
([d633753](d633753))
* **editor:** Reset canvas zoom before workspace reset in node view
([#7625](#7625))
([78b84af](78b84af))
* **editor:** Zoom in/out on canvas the same amount on scroll/gesture
([#7602](#7602))
([c92402a](c92402a))
* **Facebook Lead Ads Trigger Node:** Fix issue with missing scope for
business management ([#7616](#7616))
([32b85ba](32b85ba))


### Features

* **core:** Add the node version to telemetry in node_graph_string
([#7449](#7449))
([59dc36a](59dc36a))
* **core:** Coordinate workflow activation in multiple main scenario in
internal API ([#7566](#7566))
([c857e42](c857e42))
* **core:** Initial support for two-way communication over websockets
([#7570](#7570))
([ac87701](ac87701))
* **core:** Log executed migrations with info level
([#7586](#7586))
([7dac9ab](7dac9ab))
* **core:** Rate limit forgot password endpoint
([#7604](#7604))
([5790e25](5790e25))
* **LinkedIn Node:** Add support for Article thumbnails
([#7489](#7489))
([e6d3d1a](e6d3d1a))
* **NocoDB Node:** Add new data apis and workspace support
([#7329](#7329))
([da2d2a8](da2d2a8))

Co-authored-by: ivov <ivov@users.noreply.github.com>
@janober
Copy link
Member

janober commented Nov 8, 2023

Got released with n8n@1.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants