Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NocoDB Node): Add new data apis and workspace support #7329

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

mertmit
Copy link
Contributor

@mertmit mertmit commented Oct 3, 2023

  • Changed old NocoDB logo with new one
    To support new release of NocoDB (v0.202.4):
  • Added a new version(3) to support new data apis and workspaces
  • Renamed project to base for new version (kept labels for old versions for backwards compatibility)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Oct 3, 2023
@Joffcom
Copy link
Member

Joffcom commented Oct 3, 2023

Hey @mertmit,

Thanks for the PR, I have created NODE-827 as our internal ticket for the review.

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Oct 3, 2023
@mertmit
Copy link
Contributor Author

mertmit commented Oct 3, 2023

Hey @Joffcom,

Thank you for quick response, waiting to hear from you.

Signed-off-by: mertmit <mertmit99@gmail.com>
@mertmit mertmit changed the title feat(NocoDB Node): add new data apis and workspace support feat(NocoDB Node): Add new data apis and workspace support Oct 17, 2023
@mertmit
Copy link
Contributor Author

mertmit commented Oct 30, 2023

Hi @Joffcom,
Hope you're doing well! As 0.202.4 version and cloud version released our users need this to integrate new flows.
Could we possibly speed up the review for NODE-827?
Let me know if you need anything from my end.

@Joffcom
Copy link
Member

Joffcom commented Oct 31, 2023

Hey @mertmit,

This is on my list for this week as we have had a couple of reports of file uploads not working as well.

@Joffcom
Copy link
Member

Joffcom commented Nov 1, 2023

This looks to be working ok for me on the latest version of Noco, I will set up a local version of an older release and make sure nothing breaks as well.

@mertmit
Copy link
Contributor Author

mertmit commented Nov 2, 2023

Sure let me know if anything required from my side

@Joffcom
Copy link
Member

Joffcom commented Nov 3, 2023

Hey @mertmit,

Sorry for the delay again, I have started up a 0.111.4 instance of NocoDB and created a workflow in n8n before this change which worked but once I update n8n to use the changes here it breaks the workflow.

I suspect this is down to the node option where you can select the API version being changed to v0.200.0 onwards as the default, The Project name also vanishes which is due to the name change of project as we use the internal name field for saving it the label is just for display.

I have pushed some changes which seem to fix these in my testing, Would you be able to give it another run on your side to see if everything is ok for you as well?

@mertmit
Copy link
Contributor Author

mertmit commented Nov 3, 2023

@Joffcom those changes are working for latest version as well, thank you for the fix.

Looking forward to get this PR merged.

@Joffcom Joffcom merged commit da2d2a8 into n8n-io:master Nov 8, 2023
8 checks passed
MiloradFilipovic added a commit that referenced this pull request Nov 8, 2023
* master: (24 commits)
  fix(Crypto Node): Fix issue with value not appearing for Sign action (#7619)
  feat(NocoDB Node): Add new data apis and workspace support (#7329)
  fix(Facebook Lead Ads Trigger Node): Fix issue with missing scope for business management  (#7616)
  refactor(core): Stop reporting to Sentry missing-node-on-retry error (no-changelog) (#7648)
  fix(editor): Fix workflow history prune time limit (getting hours instead of days) (#7644)
  fix(core): Comply with custom default for workflow saving settings (#7634)
  feat(core): Initial support for two-way communication over websockets (#7570)
  ci: Conditionally re-enable coverage for frontend packages (no-changelog) (#7641)
  ci(core): Load config schema after process.env has been overwritten (no-changelog) (#7550)
  fix(core): Make password-reset urls valid only for single-use (#7622)
  fix: Error handling on forgot password page (no-changelog) (#7633)
  ci: Improve CI performance (no-changelog) (#7637)
  fix(core): Ensure pruning starts only after migrations have completed (#7626)
  feat(core): Coordinate workflow activation in multiple main scenario in internal API (#7566)
  fix(editor): Fix local storage flags defaulting to undefined string (#7603)
  fix(editor): Reset canvas zoom before workspace reset in node view (#7625)
  fix(editor): More dark-mode fixes (no-changelog) (#7624)
  fix(core): Fix accessor error when running partial execution (#7618)
  fix(editor): Fix issue that frontend breaks with unkown nodes (#7596)
  fix(core): Ensure `init` before checking leader or follower in multi-main scenario (#7621)
  ...
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
ivov added a commit that referenced this pull request Nov 8, 2023
#
[1.16.0](https://github.com/n8n-io/n8n/compare/n8n@1.15.1...n8n@1.16.0)
(2023-11-08)


### Bug Fixes

* **core:** Comply with custom default for workflow saving settings
([#7634](#7634))
([48c068f](48c068f))
* **core:** Decrease reset password token expire time
([#7598](#7598))
([2aa7f63](2aa7f63))
* **core:** Ensure `init` before checking leader or follower in
multi-main scenario ([#7621](#7621))
([a994ba5](a994ba5))
* **core:** Ensure pruning starts only after migrations have completed
([#7626](#7626))
([f748de9](f748de9))
* **core:** Fix accessor error when running partial execution
([#7618](#7618))
([26361df](26361df)),
closes [#6229](#6229)
* **core:** Make password-reset urls valid only for single-use
([#7622](#7622))
([6031424](6031424))
* **Crypto Node:** Fix issue with value not appearing for Sign action
([#7619](#7619))
([5df583f](5df583f))
* **editor:** Allow overriding theme from query params
([#7591](#7591))
([2854a0c](2854a0c))
* **editor:** Fix issue that frontend breaks with unkown nodes
([#7596](#7596))
([db56a9e](db56a9e))
* **editor:** Fix local storage flags defaulting to undefined string
([#7603](#7603))
([151e60f](151e60f))
* **editor:** Fix workflow history prune time limit (getting hours
instead of days) ([#7644](#7644))
([3d5a485](3d5a485))
* **editor:** Hide not supported node options
([#7597](#7597))
([b532a7b](b532a7b))
* **editor:** Remove unknown credentials on pasting workflow
([#7582](#7582))
([d633753](d633753))
* **editor:** Reset canvas zoom before workspace reset in node view
([#7625](#7625))
([78b84af](78b84af))
* **editor:** Zoom in/out on canvas the same amount on scroll/gesture
([#7602](#7602))
([c92402a](c92402a))
* **Facebook Lead Ads Trigger Node:** Fix issue with missing scope for
business management ([#7616](#7616))
([32b85ba](32b85ba))


### Features

* **core:** Add the node version to telemetry in node_graph_string
([#7449](#7449))
([59dc36a](59dc36a))
* **core:** Coordinate workflow activation in multiple main scenario in
internal API ([#7566](#7566))
([c857e42](c857e42))
* **core:** Initial support for two-way communication over websockets
([#7570](#7570))
([ac87701](ac87701))
* **core:** Log executed migrations with info level
([#7586](#7586))
([7dac9ab](7dac9ab))
* **core:** Rate limit forgot password endpoint
([#7604](#7604))
([5790e25](5790e25))
* **LinkedIn Node:** Add support for Article thumbnails
([#7489](#7489))
([e6d3d1a](e6d3d1a))
* **NocoDB Node:** Add new data apis and workspace support
([#7329](#7329))
([da2d2a8](da2d2a8))

Co-authored-by: ivov <ivov@users.noreply.github.com>
@janober
Copy link
Member

janober commented Nov 8, 2023

Got released with n8n@1.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants