fix(Notion Node): Fix broken Notion node parameters #7864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
OlegIvaniv
changed the title
n8n-assistant
bot
added
n8n team
michael-radency
approved these changes
Nov 29, 2023
|
✅ All Cypress E2E specs passed |
Passing run #3109 ↗︎
Details:
Review all test suite changes for PR #7864 ↗︎ |
|||||||||||||||
netroy
pushed a commit
that referenced
this pull request
Nov 29, 2023
We've introduced a new version(`2.1` of Notion node in #7791 but not all `diplayOptions` conditions were updated. This would effectively prevent most of the required Notion fields from loading. This PR adds the new version to all `@version` display conditions which contain version `2`. https://github.com/n8n-io/n8n/assets/12657221/4254c646-43b6-46b3-adcc-1b17746901da Github issue / Community forum post (link here to close automatically): --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Michael Kret <michael.k@radency.com>
Merged
netroy
pushed a commit
that referenced
this pull request
Nov 29, 2023
We've introduced a new version(`2.1` of Notion node in #7791 but not all `diplayOptions` conditions were updated. This would effectively prevent most of the required Notion fields from loading. This PR adds the new version to all `@version` display conditions which contain version `2`. https://github.com/n8n-io/n8n/assets/12657221/4254c646-43b6-46b3-adcc-1b17746901da Github issue / Community forum post (link here to close automatically): --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Michael Kret <michael.k@radency.com>
netroy
added a commit
that referenced
this pull request
Nov 29, 2023
## [1.19.2](https://github.com/n8n-io/n8n/compare/n8n@1.19.1...n8n@1.19.2) (2023-11-29) ### Bug Fixes * **AWS DynamoDB Node:** Improve error message parsing ([#7793](#7793)) ([df06163](df06163)) * **Google Sheets Node:** Fix issue with paired items not being set correctly ([#7862](#7862)) ([5827b7a](5827b7a)) * **Notion Node:** Fix broken Notion node parameters ([#7864](#7864)) ([442d449](442d449)) Co-authored-by: netroy <netroy@users.noreply.github.com>
Merged
netroy
added a commit
that referenced
this pull request
Nov 30, 2023
## [1.18.1](https://github.com/n8n-io/n8n/compare/n8n@1.18.0...n8n@1.18.1) (2023-11-30) ### Bug Fixes * **AWS DynamoDB Node:** Improve error message parsing ([#7793](#7793)) ([192770a](192770a)) * **core:** Prevent error messages due to statistics about data loading ([#7824](#7824)) ([c7d600a](c7d600a)) * **core:** Tighten checks for multi-main setup usage ([#7788](#7788)) ([060987a](060987a)) * **core:** Use AbortController to notify nodes to abort execution ([#6141](#6141)) ([dbad88d](dbad88d)) * **editor:** Disable context menu actions in read-only mode ([#7789](#7789)) ([ae25503](ae25503)) * **editor:** Fix cloud plan data loading on instance ([#7841](#7841)) ([b0039a3](b0039a3)) * **editor:** Fix credential icon for old node type version ([#7843](#7843)) ([9b0e2d1](9b0e2d1)) * **editor:** Fix icon for unknown node type ([#7842](#7842)) ([9cd0a75](9cd0a75)) * **editor:** Fix mouse position in workflow previews ([#7853](#7853)) ([83b5e6a](83b5e6a)) * **editor:** Suppress dev server websocket messages in workflow view ([#7808](#7808)) ([8a71178](8a71178)) * **Google Sheets Node:** Fix issue with paired items not being set correctly ([#7862](#7862)) ([95854db](95854db)) * **Google Sheets Node:** Read operation execute for each item ([#7800](#7800)) ([2563433](2563433)) * **HTTP Request Node:** Enable expressions for binary input data fields ([#7782](#7782)) ([7ec748a](7ec748a)) * **Microsoft SQL Node:** Prevent double escaping table name ([#7801](#7801)) ([6a8e7b1](6a8e7b1)) * **Notion Node:** Fix broken Notion node parameters ([#7864](#7864)) ([940944e](940944e)) Co-authored-by: netroy <netroy@users.noreply.github.com>
|
Got released with |
Merged
ivov
added a commit
that referenced
this pull request
Dec 6, 2023
# [1.20.0](https://github.com/n8n-io/n8n/compare/n8n@1.19.0...n8n@1.20.0) (2023-12-06) ### Bug Fixes * **AWS DynamoDB Node:** Improve error message parsing ([#7793](#7793)) ([5ba5ed8](5ba5ed8)) * **core:** Allow grace period for binary data deletion after manual execution ([#7889](#7889)) ([61d8aeb](61d8aeb)) * **core:** Consolidate ownership and sharing data on workflows and credentials ([#7920](#7920)) ([38b88b9](38b88b9)) * **core:** Fix hard deletes stopping if database query throws ([#7848](#7848)) ([46dd4d3](46dd4d3)) * **core:** Make sure mfa secret and recovery codes are not returned on login ([#7936](#7936)) ([f5502cc](f5502cc)) * **editor:** Fix deletion of last execution at execution preview ([#7883](#7883)) ([ce2d388](ce2d388)) * **editor:** Replace isInstanceOwner checks with scopes where applicable ([#7858](#7858)) ([132d691](132d691)) * **Google Sheets Node:** Fix issue with paired items not being set correctly ([#7862](#7862)) ([5207a2f](5207a2f)) * **Notion Node:** Fix broken Notion node parameters ([#7864](#7864)) ([51d1f5b](51d1f5b)), closes [#7791](#7791) ### Features * **BambooHR Node:** Add support for Only Current on company reports ([#7878](#7878)) ([4175801](4175801)) * **core:** Allow admin creation ([#7837](#7837)) ([476806e](476806e)) * **editor:** Add sections to create node panel ([#7831](#7831)) ([39fa8d2](39fa8d2)) * **editor:** Open template credential setup from collection ([#7882](#7882)) ([627ddb9](627ddb9)) * **editor:** Select credentials in template setup if theres only one ([#7879](#7879)) ([fe3417a](fe3417a)) ### Performance Improvements * **editor:** Improve node rendering performance when opening large workflows ([#7904](#7904)) ([a8049a0](a8049a0)) * **editor:** Improve performance when opening large workflows with node issues ([#7901](#7901)) ([4bd7ae2](4bd7ae2)) Co-authored-by: ivov <ivov@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've introduced a new version(
2.1of Notion node in #7791 but not alldiplayOptionsconditions were updated. This would effectively prevent most of the required Notion fields from loading.This PR adds the new version to all
@versiondisplay conditions which contain version2.CleanShot.2023-11-29.at.13.39.50.mp4
Github issue / Community forum post (link here to close automatically):