feat(editor): Update copy: Execute --> Test
#8137
Conversation
n8n-assistant
bot
added
n8n team
RicardoE105
changed the title
Execute --> Test
RicardoE105
changed the title
Execute --> TestExecute --> Test (no-changelog)
|
|
2 flaky tests on run #3617 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Screenshots
Video
|
|
29-templates.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Templates > should save template id with the workflow |
Screenshots
Video
|
|
Review all test suite changes for PR #8137 ↗︎
|
✅ All Cypress E2E specs passed |
|
|
| @@ -42,7 +42,7 @@ | |||
| { | |||
| "parameters": {}, | |||
| "id": "551313bb-1e01-4133-9956-e6f09968f2ce", | |||
| "name": "When clicking \"Execute Workflow\"", | |||
| "name": "When clicking \"Test Workflow\"", | |||
There was a problem hiding this comment.
why did you need to update the fixtures? the tests should have worked even with the old node names, right?
There was a problem hiding this comment.
they kept breaking because we were using some of then to assert the exact label, so updated it all of them
There was a problem hiding this comment.
why did they keep breaking? the node names of imported workflows should not change, right?
There was a problem hiding this comment.
Existing display names will not change! I only change it there because for some tests we were using this fixtures and asserting that the node display name was "Execute Node" instead "Test Node" so I changed it on all fixtures to avoid issues. I can revert the changes, and run the e2e tests again and only rename in the fixtures where we assert the new name.
There was a problem hiding this comment.
ah I see.. new nodes added in tests would need to be updated.. but not imported fixtures in tests.. it's your call here.. it's fine either way
mutdmour
changed the title
Execute --> Test (no-changelog)Execute --> Test
|
|
|
|
|
✅ All Cypress E2E specs passed |
## Summary Title self explanatory ## Related tickets and issues https://linear.app/n8n/issue/ADO-129/update-copy-execute-test ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
|
Got released with |
Summary
Title self explanatory
Related tickets and issues
https://linear.app/n8n/issue/ADO-129/update-copy-execute-test
Review / Merge checklist
(no-changelog)otherwise. (conventions)