fix: AI agents, throw error on duplicate names in dynamic tools #8766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
node/improvement
OlegIvaniv
requested changes
Feb 29, 2024
packages/@n8n/nodes-langchain/nodes/agents/OpenAiAssistant/OpenAiAssistant.node.ts
Show resolved
Hide resolved
Co-authored-by: oleg <me@olegivaniv.com>
…ttps://github.com/n8n-io/n8n into ai-95-error-if-we-have-two-tools-with-the-same-name
OlegIvaniv
previously approved these changes
Feb 29, 2024
2 flaky tests on run #4252 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8766 ↗︎
|
✅ All Cypress E2E specs passed |
This reverts commit f02cda7.
OlegIvaniv
approved these changes
Feb 29, 2024
|
✅ All Cypress E2E specs passed |
michael-radency
deleted the
ai-95-error-if-we-have-two-tools-with-the-same-name
branch
netroy
pushed a commit
that referenced
this pull request
Mar 6, 2024
Co-authored-by: oleg <me@olegivaniv.com>
Merged
|
Got released with |
Merged
TaylorHo
pushed a commit
to TaylorHo/n8n
that referenced
this pull request
Mar 17, 2024
…io#8766) Co-authored-by: oleg <me@olegivaniv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Error if we have two tools with the same name
Related tickets and issues
https://linear.app/n8n/issue/AI-95/error-if-we-have-two-tools-with-the-same-name