fix(HubSpot Node): Include properties for contact and deal in getAll operation #8772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hubspot-v2-contact-properties-to-include-does-not-work
michael-radency
added
n8n team
maspio
approved these changes
Feb 29, 2024
|
✅ All Cypress E2E specs passed |
2 flaky tests on run #4255 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
5-ndv.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8772 ↗︎
michael-radency
deleted the
node-604-hubspot-v2-contact-properties-to-include-does-not-work
branch
netroy
pushed a commit
that referenced
this pull request
Mar 5, 2024
Closed
netroy
pushed a commit
that referenced
this pull request
Mar 6, 2024
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you use the Contact Properties to Include option with the Hubspot v2 node (Contact > Get Many) it doesn't appear to make any change to the returned output.
The field to select the properties is also horrible to use, It is not alphabetical and you can't search for a value.
Related tickets and issues
https://community.n8n.io/t/hubspot-get-many-contacts-v2-doensnt-include-additonal-properties/27412
https://community.n8n.io/t/hubspot-deal-getmany-does-not-return-the-requested-deal-properties/40125/2
https://linear.app/n8n/issue/NODE-604/hubspot-v2-contact-properties-to-include-does-not-work