fix: Simplify Structured Output Parser wrapping and fix auto-fixing output parser #8778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rapping and fix auto-fixing output parser Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
OlegIvaniv
force-pushed
the
ai-101-auto-wrap-output-parser-json-if-not-in-correct-format
branch
from
7561d49
to
1b94c60
Compare
2 flaky tests on run #4257 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
19-execution.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Execution > should test manual workflow stop |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8778 ↗︎
|
|
OlegIvaniv
changed the title
|
✅ All Cypress E2E specs passed |
OlegIvaniv
deleted the
ai-101-auto-wrap-output-parser-json-if-not-in-correct-format
branch
netroy
pushed a commit
that referenced
this pull request
Mar 5, 2024
…utput parser (#8778) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Closed
netroy
pushed a commit
that referenced
this pull request
Mar 6, 2024
…utput parser (#8778) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Merged
|
Got released with |
Merged
TaylorHo
pushed a commit
to TaylorHo/n8n
that referenced
this pull request
Mar 17, 2024
…utput parser (n8n-io#8778) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
1.1version of Structured Output Parser, universally wrapping it inoutputinstead of letting the LM choose the wrapping approachOutputParserExceptionwhen calling parsing method, since Langchain relies on it to run the retry chain for auto-fixing the outputRelated tickets and issues
Review / Merge checklist
(no-changelog)otherwise. (conventions)