Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AI Error Debugging using OpenAI #8805

Merged
merged 13 commits into from
Mar 13, 2024
Merged

Conversation

alexgrozav
Copy link
Contributor

Summary

Introduces AI Error Debugging using OpenAI.

Adds two new environment variables:

  • N8N_AI_PROVIDER
  • N8N_AI_OPENAI_API_KEY

The N8N_AI_OPENAI_API_KEY environment variable is required in order for the feature to be available.

image

Related tickets and issues

https://linear.app/n8n/project/error-debugging-using-ai-133101058b93/AI

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@alexgrozav alexgrozav self-assigned this Mar 5, 2024
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 5, 2024
Base automatically changed from node-856-improve-errors-in-output-panel to master March 7, 2024 16:08
@alexgrozav alexgrozav marked this pull request as ready for review March 8, 2024 11:46
packages/cli/src/services/ai.service.ts Show resolved Hide resolved
packages/cli/src/services/ai.service.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/components/Feedback.vue Outdated Show resolved Hide resolved
packages/editor-ui/src/plugins/i18n/locales/en.json Outdated Show resolved Hide resolved
OlegIvaniv
OlegIvaniv previously approved these changes Mar 13, 2024
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my points, LGTM and awesome job!

Copy link

cypress bot commented Mar 13, 2024

1 flaky test on run #4368 ↗︎

0 343 12 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project: n8n Commit: 6ce942629a
Status: Passed Duration: 03:49 💡
Started: Mar 13, 2024 2:35 PM Ended: Mar 13, 2024 2:39 PM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video

Review all test suite changes for PR #8805 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 948c383 into master Mar 13, 2024
28 checks passed
@alexgrozav alexgrozav deleted the ai-error-debugging branch March 13, 2024 14:48
@alexgrozav alexgrozav restored the ai-error-debugging branch March 13, 2024 15:03
@alexgrozav alexgrozav deleted the ai-error-debugging branch March 13, 2024 15:03
@krynble
Copy link
Contributor

krynble commented Mar 13, 2024

Hey yall, are those new dependencies needed in the cli package? Langchain alone is 4mb in size, and I'm wondering about the memory consumption as well.

It seems we're not heavily using the langchain stuff, but rather adding tooling and debugging.

Would it make sense to consider having those classes as part of the langchain-dedicated code?

@alexgrozav @OlegIvaniv

@alexgrozav
Copy link
Contributor Author

@krynble We have plans to move these out into a separate AI Service sometime in the future. We're currently shipping these AI features as fast as we can, and adapt as we go.

@github-actions github-actions bot mentioned this pull request Mar 20, 2024
@janober
Copy link
Member

janober commented Mar 20, 2024

Got released with n8n@1.34.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants