fix(core): Always register webhooks on startup #8830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
OlegIvaniv
approved these changes
Mar 7, 2024
2 flaky tests on run #4310 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
17-sharing.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8830 ↗︎
|
✅ All Cypress E2E specs passed |
|
Got released with |
krynble
added a commit
that referenced
this pull request
Mar 7, 2024
netroy
changed the title
despairblue
pushed a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On version 1.15 we stopped deregistering webhooks on shutdown but on 1.28 we also stopped registering on init, given that if a workflow was already active, the database would be populated.
The problem is that users upgrading from < 1.15 to >= 1.28 would end up with webhooks not registered at all, so this changes prevents this from happening by always ensuring webhooks are registered.
Related tickets and issues
https://linear.app/n8n/issue/HELP-479/webhooks-not-working-after-upgrade
Review / Merge checklist
(no-changelog)otherwise. (conventions)