Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Webhook Node): Overhaul #8889

Merged
merged 40 commits into from
Mar 28, 2024
Merged

feat(Webhook Node): Overhaul #8889

merged 40 commits into from
Mar 28, 2024

Conversation

michael-radency
Copy link
Contributor

Summary

Overhaul

Related tickets and issues

https://linear.app/n8n/issue/NODE-1229/webhook-node-overhaul

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team labels Mar 14, 2024
michael-radency and others added 26 commits March 15, 2024 10:59
@michael-radency
⚡ setup
c4b1939
@michael-radency
⚡ response code selector
cbaaaa9
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1229-…
0bc3997 
…webhook-node-overhaul
@michael-radency
⚡ url and mode in webhook json item
a590c29
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1229-…
8d4767e 
…webhook-node-overhaul
@michael-radency
⚡ multiple cors origins support, ips whitelist
dc41282
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1229-…
4557d0e 
…webhook-node-overhaul
@michael-radency
⚡ jwt auth setup
cde2f0b
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1229-…
5698f02 
…webhook-node-overhaul
@michael-radency
⚡ jwt payload, respond with jwt token option
ec99b3b
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1229-…
62d8fc7 
…webhook-node-overhaul
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1229-…
9f7c7f0 
…webhook-node-overhaul
@michael-radency
⚡ respond to webhook configuration errors
65f2665
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1229-…
157cc6b 
…webhook-node-overhaul
@michael-radency
⚡ throw an actual node operation or api error, not just message with …
c1cf8d4 
…stack
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1229-…
c618452 
…webhook-node-overhaul
@michael-radency
⚡ removed multiple methods support
d1aaf51
@michael-radency
⚡ responseCode selector option
3af8077
@michael-radency
⚡ clean up, jwt icon update
e5b8eb0
@michael-radency
⚡ fix for responseData option
9b61137
@michael-radency
⚡ path description update
37fbed2
@michael-radency
⚡ jwt credentials update, PEM keys support
9092533
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1229-…
fd96ea7 
…webhook-node-overhaul
@michael-radency
⚡ credentials check fix in webhook node, options order fix
fd37661
@gandreini
Various copy tweaks. Reduced the number of available codes.
e3fc996
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1229-…
6507c10 
…webhook-node-overhaul
@cypress Cypress
Copy link

cypress bot commented Mar 26, 2024 •
edited
Loading

1 flaky test on run #4492 ↗︎

0 343 12 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: 7e65050694
Status: Passed Duration: 03:51 💡
Started: Mar 28, 2024 8:40 AM Ended: Mar 28, 2024 8:44 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video

Review all test suite changes for PR #8889 ↗︎

elsmr
elsmr reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@elsmr elsmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🎉 left some minor comments/questions

packages/core/src/NodeExecuteFunctions.ts Outdated Show resolved Hide resolved
packages/core/src/NodeExecuteFunctions.ts Outdated Show resolved Hide resolved
packages/core/src/NodeExecuteFunctions.ts Outdated Show resolved Hide resolved
packages/nodes-base/nodes/Webhook/utils.ts Outdated Show resolved Hide resolved
elsmr
elsmr previously approved these changes Mar 27, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit e84c27c into master Mar 28, 2024
28 checks passed
@michael-radency michael-radency deleted the node-1229-webhook-node-overhaul branch March 28, 2024 08:46
@github-actions github-actions bot mentioned this pull request Apr 3, 2024
Merged
@janober
Copy link
Member

janober commented Apr 3, 2024

Got released with n8n@1.36.0

@ivov ivov mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsmr elsmr elsmr approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michael-radency @janober @elsmr @gandreini