Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Make Webhook node pinnable #9047

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Apr 3, 2024

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Apr 3, 2024

2 flaky tests on run #4541 ↗︎

0 348 12 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: ac1b2fece5
Status: Passed Duration: 43:42 💡
Started: Apr 3, 2024 2:50 PM Ended: Apr 3, 2024 3:34 PM
Flakiness  cypress/e2e/5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
NDV > Stop listening for trigger event from NDV Test Replay Screenshots Video

Review all test suite changes for PR #9047 ↗︎

Copy link
Contributor

github-actions bot commented Apr 3, 2024

✅ All Cypress E2E specs passed

@ivov ivov merged commit 042aa62 into master Apr 3, 2024
28 checks passed
@ivov ivov deleted the pay-1488-webhook-node-output-cannot-be-pinned branch April 3, 2024 15:41
MiloradFilipovic added a commit that referenced this pull request Apr 4, 2024
* master:
  fix(core): Ensure `status` on Axios errors is available to the BE (#9015)
  fix(editor): Make Webhook node pinnable (#9047)
  fix(core): Upgrade express to address CVE-2024-29041 (no-changelog) (#9021)
  fix(editor): Add fallback for expression resolution in multi-output case (#9045)
  ci(core): Upgrade express-openapi-validator (no-changelog) (#9022)
  refactor(core): Delete all auth exclusion config and checks (no-changelog) (#9044)
  fix(editor): Make share modal content scrollable (#9025)
MiloradFilipovic added a commit that referenced this pull request Apr 4, 2024
* master:
  fix(core): Ensure `status` on Axios errors is available to the BE (#9015)
  fix(editor): Make Webhook node pinnable (#9047)
  fix(core): Upgrade express to address CVE-2024-29041 (no-changelog) (#9021)
  fix(editor): Add fallback for expression resolution in multi-output case (#9045)
  ci(core): Upgrade express-openapi-validator (no-changelog) (#9022)
  refactor(core): Delete all auth exclusion config and checks (no-changelog) (#9044)
  fix(editor): Make share modal content scrollable (#9025)
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@janober
Copy link
Member

janober commented Apr 5, 2024

Got released with n8n@1.36.1

@github-actions github-actions bot mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants