fix(editor): Canvas showing error toast when clicking outside of "import workflow by url" modal #9001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
RicardoE105
changed the title
RicardoE105
changed the title
n8n-assistant
bot
added
n8n team
MiloradFilipovic
previously approved these changes
Apr 2, 2024
|
✅ All Cypress E2E specs passed |
2 flaky tests on run #4554 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
17-sharing.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9001 ↗︎
MiloradFilipovic
previously approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Nice! Thanks for addressing. One nitpick though: Does it make sense to move other tests that are testing workflow import (like this one) to this file also? Now we are having them in a few places which can be confusing
|
|
|
Good catch, @MiloradFilipovic. That is most likely the same test. I will probably delete the one you mentioned and keep this separate file. |
MiloradFilipovic
approved these changes
Apr 4, 2024
|
✅ All Cypress E2E specs passed |
RicardoE105
deleted the
ado-960-closing-import-form-url-modal-by-clicking-outside-causes
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 4, 2024
* master: fix(core): Ensure only leader handles waiting executions (#9014) fix(editor): Fix execution with wait node (#9051) fix(editor): Issue showing Auth2 callback section when all properties are overriden (#8999) fix(editor): Rerun failed nodes in manual executions (#9050) fix(editor): Canvas showing error toast when clicking outside of "import workflow by url" modal (#9001) fix: Workflows executed from other workflows not stopping (#9010) fix: Fix missing input panel in node details view (#9043) fix(editor): Prevent saving workflow while another save is in progress (#9048)
despairblue
pushed a commit
that referenced
this pull request
Apr 4, 2024
…ort workflow by url" modal (#9001)
Merged
despairblue
pushed a commit
that referenced
this pull request
Apr 4, 2024
…ort workflow by url" modal (#9001)
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FE attempted to import workflow even when the modal was closed - by clicking outside the modal.
Before:
https://www.loom.com/share/67ab4c920c334ecfa7ac1341603c882a
Now:
https://www.loom.com/share/8ce132a9edd2423a9995c05a07982c29
Related tickets and issues
https://linear.app/n8n/issue/ADO-960/closing-import-form-url-modal-by-clicking-outside-causes-error
Review / Merge checklist
(no-changelog)otherwise. (conventions)