Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix execution with wait node #9051

Merged

Conversation

cstuncsik
Copy link
Contributor

CleanShot.2024-04-04.at.10.18.50.mp4

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Apr 4, 2024
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

cypress bot commented Apr 4, 2024

1 flaky test on run #4558 ↗︎

0 348 12 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: e470d9b7bf
Status: Passed Duration: 04:01 💡
Started: Apr 4, 2024 10:27 AM Ended: Apr 4, 2024 10:31 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > Stop listening for trigger event from NDV Test Replay Screenshots Video

Review all test suite changes for PR #9051 ↗︎

Copy link
Contributor

github-actions bot commented Apr 4, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

github-actions bot commented Apr 4, 2024

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit db4f8d4 into master Apr 4, 2024
28 checks passed
@cstuncsik cstuncsik deleted the pay-1489-manual-execution-with-wait-node-throws-error branch April 4, 2024 10:33
MiloradFilipovic added a commit that referenced this pull request Apr 4, 2024
* master:
  fix(core): Ensure only leader handles waiting executions (#9014)
  fix(editor): Fix execution with wait node (#9051)
  fix(editor): Issue showing Auth2 callback section when all properties are overriden (#8999)
  fix(editor): Rerun failed nodes in manual executions (#9050)
  fix(editor): Canvas showing error toast when clicking outside of "import workflow by url" modal (#9001)
  fix: Workflows executed from other workflows not stopping (#9010)
  fix: Fix missing input panel in node details view (#9043)
  fix(editor): Prevent saving workflow while another save is in progress (#9048)
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@janober
Copy link
Member

janober commented Apr 5, 2024

Got released with n8n@1.36.1

@github-actions github-actions bot mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants