feat: Allow workflow execution even if it has errors #9037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi
force-pushed
the
ado-1655-bug-change-exec-logic-when-downstream-node-has-issue
branch
from
36f12dd
to
c74aac1
Compare
n8n-assistant
bot
added
n8n team
Backend does execute the workflow up to the node(s) that have issues. That way the workflow can be partially tested even if it's e.g. missing credentials.
tomi
force-pushed
the
ado-1655-bug-change-exec-logic-when-downstream-node-has-issue
branch
from
c74aac1
to
4925aa8
Compare
1 flaky test on run #4528 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9037 ↗︎
|
✅ All Cypress E2E specs passed |
tomi
deleted the
ado-1655-bug-change-exec-logic-when-downstream-node-has-issue
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backend does execute the workflow up to the node(s) that have issues. That way the workflow can be partially tested even if it's e.g. missing credentials.
Kapture.2024-04-03.at.12.18.05.mp4
Related tickets and issues
https://linear.app/n8n/issue/ADO-1655/bug-change-exec-logic-when-downstream-node-has-issue
Review / Merge checklist
(no-changelog)otherwise. (conventions)