fix(editor): Drop outgoing connections on order changed event for nodes with dynamic outputs #9055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
ui
michael-radency
changed the title
…switch-reordering-changes-which-nodes-are-connected-to-which
OlegIvaniv
requested changes
Apr 5, 2024
| @@ -853,6 +857,20 @@ export default defineComponent({ | |||
| return; | |||
| } | |||
|
|
|||
| if ( | |||
| parameterData.type && | |||
| SHOULD_CLEAR_NODE_OUTPUTS[nodeType.name] && | |||
There was a problem hiding this comment.
Eslint warning here: Prefer using an optional chain expression instead, as it's more concise and easier to read.eslint[@typescript-eslint/prefer-optional-chain](https://typescript-eslint.io/rules/prefer-optional-chain)
Comment on lines
203
to
212
| clearNodeOutgoingConnections() { | ||
| const uiStore = useUIStore(); | ||
| return (nodeName: string): void => { | ||
| if (this.workflow.connections.hasOwnProperty(nodeName)) { | ||
| this.workflow.connections[nodeName] = {}; | ||
| uiStore.stateIsDirty = true; | ||
| return; | ||
| } | ||
| }; | ||
| }, |
There was a problem hiding this comment.
This shouldn't be a getter but rather an action
| @@ -1093,6 +1093,8 @@ | |||
| "nodeSettings.latest": "Latest", | |||
| "nodeSettings.deprecated": "Deprecated", | |||
| "nodeSettings.latestVersion": "Latest version: {version}", | |||
| "nodeSettings.outputCleared.title": "Parameters changed", | |||
| "nodeSettings.outputCleared.message": "Order of parameters changed, outgoing connections was cleared", | |||
There was a problem hiding this comment.
Order of parameters changed, outgoing connections were cleared.
…switch-reordering-changes-which-nodes-are-connected-to-which
…switch-reordering-changes-which-nodes-are-connected-to-which
…switch-reordering-changes-which-nodes-are-connected-to-which
OlegIvaniv
reviewed
Apr 8, 2024
OlegIvaniv
changed the title
…switch-reordering-changes-which-nodes-are-connected-to-which
OlegIvaniv
approved these changes
Apr 8, 2024
|
✅ All Cypress E2E specs passed |
2 flaky tests on run #4625 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9055 ↗︎
michael-radency
deleted the
node-1273-switch-reordering-changes-which-nodes-are-connected-to-which
branch
Merged
|
Got released with |
netroy
pushed a commit
that referenced
this pull request
Apr 11, 2024
…es with dynamic outputs (#9055)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because of Switch outputs are configured dynamically, based on rules, we are disconnecting connected nodes on rules reorder and show a warning in UI
Related tickets and issues
https://linear.app/n8n/issue/NODE-1273/switch-reordering-changes-which-nodes-are-connected-to-which-outputs
https://community.n8n.io/t/reorder-outputs-in-switch-does-not-reorder-output-connections/43302